From patchwork Fri Dec 22 13:48:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Lothian X-Patchwork-Id: 10130523 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DBB1B60318 for ; Fri, 22 Dec 2017 13:49:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C93CD29415 for ; Fri, 22 Dec 2017 13:49:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BDECD29E33; Fri, 22 Dec 2017 13:49:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, HTML_MESSAGE, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B584429415 for ; Fri, 22 Dec 2017 13:49:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AFB2D6E737; Fri, 22 Dec 2017 13:49:08 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qk0-x22b.google.com (mail-qk0-x22b.google.com [IPv6:2607:f8b0:400d:c09::22b]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDCE96E737 for ; Fri, 22 Dec 2017 13:49:07 +0000 (UTC) Received: by mail-qk0-x22b.google.com with SMTP id q14so22065237qke.7 for ; Fri, 22 Dec 2017 05:49:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fireburn-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QTfRkxUVbYZaRxKraljyiZVSef8/XZkfIsfpt1JavXw=; b=Pg9JyqUUOQYKxB2kLgvBhXR+ITrOzCaU1vXBEB7d3F8ssC8YYFUGFx0KAP7ulxPyme LAuV2fwfdV/HkZ1J1JxGl3fvt+NEhXwNUFO5VRkGi5xcndH0h4ALM4XfDbGTU4QDT6aw QaU56IfNYASFE/ouQ+edfhxCFX+S6f8B1lEpq8aJLBXD2T0ZUrovCrMga/fhYkCJt+2V 0RlsH8lOqqTPW2tvAxi8OJbYxTc8Pb47UhtZghsavyNDG8YVlFXekIukNuzepj+gJ6h3 NfV/gP9qLotS7AnzZbXO/YdQdONpRPHGFQ2OXwdZcfQ65tpnJM8r8qCFNX4KUMojeRKv 8PPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QTfRkxUVbYZaRxKraljyiZVSef8/XZkfIsfpt1JavXw=; b=FXM/NR/6pbP5FCXvVedOllyHQ4sOeNsAzIj4dI+Gl7cjbebGCCTzCqee3amdLua9vs XkP4zeITcYStFdU9SBv+da1zMa+LtI1TPfjhX6rdIuNoIcABwyR1h7UcUO1e6tjtbORd DXABTPseC5B70MuXvp7QqbInLWbxXrZqnD6YxgiPmiDJPwSRmUNCfec2czdqRD50vrEr V6nbQEmhBosOiiXM6g7aY2GTdjySlPgC8Hzyu9a4cfsEK1k0J7d1RrJSzkw+P7UJjxk+ VoaPpNK5106PO2BhUgElg1vjoU+MtaZcsc1favPD2mzlnpnJkgOqrP7+ZMEqyQZ+niqU aFfg== X-Gm-Message-State: AKGB3mL8/XC6DEdyHwusb4pSV9SRaHOtP0yOJH+QwEb4x3lWM/PnhFP5 IpNxr7kOPZbX5zMEcfPvwFeYHX2K8Xu3qZJkqGgiREM/6+M= X-Google-Smtp-Source: ACJfBotgJP4d25kmMBLv6pFFTPrwCfjoX/zxZ5BJ9iIpOlclL8F3wjRA3djzpLY6OQJ90fVUNmVOWydtQC2kOVfFbTA= X-Received: by 10.55.122.135 with SMTP id v129mr19882463qkc.104.1513950546640; Fri, 22 Dec 2017 05:49:06 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Mike Lothian Date: Fri, 22 Dec 2017 13:48:55 +0000 Message-ID: Subject: Re: Initial release of AMD Open Source Driver for Vulkan To: "Mao, David" Cc: "mesa-dev@lists.freedesktop.org" , Maling list - DRI developers , "amd-gfx@lists.freedesktop.org" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Congratulations on getting this out the door It didn't compile for me without these changes: In pal: switch (type) diff --git a/src/util/math.cpp b/src/util/math.cpp index 46e9ede..3af4259 100644 --- a/src/util/math.cpp +++ b/src/util/math.cpp @@ -54,7 +54,7 @@ static uint32 Float32ToFloatN(float f, const NBitFloatInfo& info); static float FloatNToFloat32(uint32 fBits, const NBitFloatInfo& info); // Initialize the descriptors for various N-bit floating point representations: -static constexpr NBitFloatInfo Float16Info = +static NBitFloatInfo Float16Info = { 16, // numBits 10, // numFracBits @@ -72,7 +72,7 @@ static constexpr NBitFloatInfo Float16Info = (23 - 10), // fracBitsDiff }; -static constexpr NBitFloatInfo Float11Info = +static NBitFloatInfo Float11Info = { 11, // numBits 6, // numFracBits @@ -90,7 +90,7 @@ static constexpr NBitFloatInfo Float11Info = 23 - 6, // fracBitsDiff }; -static constexpr NBitFloatInfo Float10Info = +static NBitFloatInfo Float10Info = { 10, // numBits 5, // numFracBits In xgl: diff --git a/icd/CMakeLists.txt b/icd/CMakeLists.txt index 4e4d669..5006184 100644 --- a/icd/CMakeLists.txt +++ b/icd/CMakeLists.txt @@ -503,16 +503,16 @@ if (UNIX) target_link_libraries(xgl PRIVATE c stdc++ ${CMAKE_DL_LIBS} pthread) - if(NOT ICD_USE_GCC) - message(WARNING "Intel ICC untested in CMake.") - target_link_libraries(xgl PRIVATE -fabi-version=0 -static-intel) - endif() + #if(NOT ICD_USE_GCC) + # message(WARNING "Intel ICC untested in CMake.") + # target_link_libraries(xgl PRIVATE -fabi-version=0 -static-intel) + #endif() if(CMAKE_BUILD_TYPE_RELEASE) if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") execute_process(COMMAND ${CMAKE_C_COMPILER} -dumpversion OUTPUT_VARIABLE GCC_VERSION) if (GCC_VERSION VERSION_GREATER 5.3 OR GCC_VERSION VERSION_EQUAL 5.3) - target_link_libraries(xgl PRIVATE -flto=4 -fuse-linker-plugin -Wno-odr) + target_link_libraries(xgl PRIVATE -Wno-odr) message(WARNING "LTO enabled for Linking") endif() endif() @@ -530,17 +530,17 @@ if (UNIX) # CMAKE-TODO: What is whole-archive used for? #target_link_libraries(xgl -Wl,--whole-archive ${ICD_LIBS} -Wl,--no-whole-archive) - if(CMAKE_BUILD_TYPE_RELEASE) - execute_process(COMMAND ${CMAKE_C_COMPILER} -dumpversion OUTPUT_VARIABLE GCC_VERSION) - if (GCC_VERSION VERSION_GREATER 5.3 OR GCC_VERSION VERSION_EQUAL 5.3) - target_link_libraries(xgl PRIVATE -Wl,--whole-archive ${PROJECT_BINARY_DIR}/pal/src/libpal.a -Wl,--no-whole-archive) - target_link_libraries(xgl PUBLIC -Wl,--whole-archive ${PROJECT_BINARY_DIR}/pal/metrohash/libmetrohash.a -Wl,--no-whole-archive) - target_link_libraries(xgl PUBLIC -Wl,--whole-archive ${PROJECT_BINARY_DIR}/pal/gpuopen/libgpuopen.a -Wl,--no-whole-archive) - target_link_libraries(xgl PUBLIC -Wl,--whole-archive ${PROJECT_BINARY_DIR}/pal/vam/libvam.a -Wl,--no-whole-archive) - target_link_libraries(xgl PUBLIC -Wl,--whole-archive ${PROJECT_BINARY_DIR}/pal/addrlib/libaddrlib.a -Wl,--no-whole-archive) - target_link_libraries(xgl PUBLIC -Wl,--whole-archive ${PROJECT_BINARY_DIR}/pal/jemalloc/libjemalloc.a -Wl,--no-whole-archive) - endif() - endif() + #if(CMAKE_BUILD_TYPE_RELEASE) + # execute_process(COMMAND ${CMAKE_C_COMPILER} -dumpversion OUTPUT_VARIABLE GCC_VERSION) + # if (GCC_VERSION VERSION_GREATER 5.3 OR GCC_VERSION VERSION_EQUAL 5.3) + # target_link_libraries(xgl PRIVATE -Wl,--whole-archive ${PROJECT_BINARY_DIR}/pal/src/libpal.a -Wl,--no-whole-archive) + # target_link_libraries(xgl PUBLIC -Wl,--whole-archive ${PROJECT_BINARY_DIR}/pal/metrohash/libmetrohash.a -Wl,--no-whole-archive) + # target_link_libraries(xgl PUBLIC -Wl,--whole-archive ${PROJECT_BINARY_DIR}/pal/gpuopen/libgpuopen.a -Wl,--no-whole-archive) + # target_link_libraries(xgl PUBLIC -Wl,--whole-archive ${PROJECT_BINARY_DIR}/pal/vam/libvam.a -Wl,--no-whole-archive) + # target_link_libraries(xgl PUBLIC -Wl,--whole-archive ${PROJECT_BINARY_DIR}/pal/addrlib/libaddrlib.a -Wl,--no-whole-archive) + # target_link_libraries(xgl PUBLIC -Wl,--whole-archive ${PROJECT_BINARY_DIR}/pal/jemalloc/libjemalloc.a -Wl,--no-whole-archive) + # endif() + #endif() #${ICD_TARGET}.so${SO_VERSION_NUMBER} : ${filter-out -Wl%,$(LLLIBS}) diff --git a/icd/api/llpc/util/llpcDebug.cpp b/icd/api/llpc/util/llpcDebug.cpp index 1273cd6..847786e 100644 --- a/icd/api/llpc/util/llpcDebug.cpp +++ b/icd/api/llpc/util/llpcDebug.cpp @@ -113,7 +113,7 @@ bool EnableErrs() // Translates enum "ResourceMappingNodeType" to string and output to ostream. raw_ostream& operator<<( raw_ostream& out, // [out] Output stream - enum class ResourceMappingNodeType type) // Resource map node type + enum ResourceMappingNodeType type) // Resource map node type { const char* pString = nullptr;