From patchwork Wed Sep 18 08:15:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 2910501 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3881BBFF05 for ; Thu, 19 Sep 2013 09:37:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9AC2820443 for ; Thu, 19 Sep 2013 09:37:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 3835820164 for ; Thu, 19 Sep 2013 09:37:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 23032E6C43 for ; Thu, 19 Sep 2013 02:37:53 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ob0-f181.google.com (mail-ob0-f181.google.com [209.85.214.181]) by gabe.freedesktop.org (Postfix) with ESMTP id B98B8E5BF9 for ; Wed, 18 Sep 2013 01:15:11 -0700 (PDT) Received: by mail-ob0-f181.google.com with SMTP id gq1so6791002obb.26 for ; Wed, 18 Sep 2013 01:15:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Vz8qojXMtvclIz+vlrEz6vhAyr8mELaxBl707e357yE=; b=kYP00P4hoz9R6e0tqV+axodT8XTbCqprsE5gxhSWXifoX79O5POAIytZ4rUCfTVrnE //pFhPtgd9ceDrPd2gtlSqxQ1/1U8tTIkUJygT+waBPTuQFtyGMIGQ3T9yHtfTEwZNgH 8qhZYNJVwkZTdTQ2wSHTLj2fm83KiyCN7TTOhe2nNH34Xo1LPygm2/MfXi91QFcPpd24 fqFwh+JCmlCB0jYJQQF3bL+7ylvQPpVc0ZcP81AyrejqmSGSKaNFTkFLhj6ojyXmSmhk 4ku86IVYlqT58ys7SrC+Ww9BMIRVe+yWca4JR3eXF3YgkIEoMl4HXkIU8DjqQOrRDq/p vpWg== X-Gm-Message-State: ALoCoQmjAz585wgmLskGmySkVVNnSDuiux+bQvdLQBtH2fEQUwuAD1/vaOpDVPyBGClvTl7rcnhL MIME-Version: 1.0 X-Received: by 10.182.99.231 with SMTP id et7mr33721464obb.10.1379492111244; Wed, 18 Sep 2013 01:15:11 -0700 (PDT) Received: by 10.60.45.7 with HTTP; Wed, 18 Sep 2013 01:15:11 -0700 (PDT) In-Reply-To: <52394CB7.7080509@samsung.com> References: <52394CB7.7080509@samsung.com> Date: Wed, 18 Sep 2013 13:45:11 +0530 Message-ID: Subject: Re: [drm/exynos-fimd] Display regression in v3.12-rc1 From: Sachin Kamat To: Andrzej Hajda X-Mailman-Approved-At: Thu, 19 Sep 2013 02:34:09 -0700 Cc: Vikas Sajjan , "dri-devel@lists.freedesktop.org" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Andrzej, Thanks for your quick response. Removing display-timings::clock-frequency property from arch/arm/boot/dts/exynos4210-origen.dts fixed this issue. However, I also had to remove the same from drivers/video/of_display_timing.c as shown below, else probe fails. I will send a patch to fix the Origen dts file. Thanks for your help. 8<------------------------------------------------------------------------------------------- -- With warm regards, Sachin On 18 September 2013 12:18, Andrzej Hajda wrote: > Hi Sachin, > > Could you test it with removed display-timings::clock-frequency property. > Currently in arch/arm/boot/dts/exynos4210-origen.dts > display-timings::clock-frequency is set to 50000, > this is incorrect value. With the property removed fimd calculates > clock-frequency from other properties with assumption of default > 60Hz refresh rate. > > It could work before because of_get_fb_videomode calculated refresh rate > from display-timings and with clock 50000, the result was 0(due to > rounding down in some division), > so fimd assumed he should use default refresh rate of 60Hz. > > Regards > Andrzej > > On 09/18/2013 07:22 AM, Sachin Kamat wrote: >> Hi Andrzej , >> >> I was testing the latest Linux kernel release (v3.12-rc1) on >> Exynos4210 based Origen board. >> I found a display regression with that. I do not get any display on >> the LCD (other than backlight) with the latest kernel. Git bisect >> pointed me to the following commit: >> 111e6055d4e0d35c6a4b6cd37d7bb00a88eaffb4 ("drm/exynos: fimd: replace >> struct fb_videomode with videomode"). Reverting this patch does not >> cause the issue. Let me know if you need any other info to help >> identify the problem. >> > diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c index 171821d..4e991e1 100644 --- a/drivers/video/of_display_timing.c +++ b/drivers/video/of_display_timing.c @@ -72,7 +72,6 @@ static int of_parse_display_timing(const struct device_node *np, ret |= parse_timing_property(np, "vfront-porch", &dt->vfront_porch); ret |= parse_timing_property(np, "vactive", &dt->vactive); ret |= parse_timing_property(np, "vsync-len", &dt->vsync_len); - ret |= parse_timing_property(np, "clock-frequency", &dt->pixelclock); dt->flags = 0;