diff mbox series

drm/syncobj: flatten dma_fence_chains on transfer

Message ID DM4PR12MB515234346C965FD8936F5DEFE3809@DM4PR12MB5152.namprd12.prod.outlook.com (mailing list archive)
State New, archived
Headers show
Series drm/syncobj: flatten dma_fence_chains on transfer | expand

Commit Message

Jesse Zhang July 6, 2022, 10:41 a.m. UTC
[AMD Official Use Only - General]

Fix sync syncobj issue by enable the signaling of the base fence.

Comments

Jesse Zhang July 6, 2022, 10:46 a.m. UTC | #1
[AMD Official Use Only - General]

+ Lionel

From: Zhang, Jesse(Jie)
Sent: Wednesday, 6 July 2022 6:41 pm
To: dri-devel-bounces@lists.freedesktop.org; open list:DRM DRIVERS <dri-devel@lists.freedesktop.org>
Cc: Koenig, Christian <Christian.Koenig@amd.com>; lucas.demarchi@intel.com; Nirmoy Das <nirmoy.das@linux.intel.com>
Subject: drm/syncobj: flatten dma_fence_chains on transfer


[AMD Official Use Only - General]

Fix sync syncobj issue by enable the signaling of the base fence.


diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
index d5db818f1c76..971ad97a2f54 100644
--- a/drivers/gpu/drm/drm_syncobj.c
+++ b/drivers/gpu/drm/drm_syncobj.c
@@ -887,6 +887,7 @@ static int drm_syncobj_flatten_chain(struct dma_fence **f)
                goto free_fences;

        dma_fence_put(*f);
+       dma_fence_enable_sw_signaling(&array->base);
        *f = array->fences[0];
        return 0;
Christian König July 6, 2022, 10:47 a.m. UTC | #2
Hi Jesse,

not sure how you created this, but usually we use "git send-email" to 
send out patches. That one here looks kind of mangled.

Additional to that this is most likely not the right place for the call.

Regards,
Christian.

Am 06.07.22 um 12:41 schrieb Zhang, Jesse(Jie):
>
> [AMD Official Use Only - General]
>
>
> Fix sync syncobj issue by enable the signaling of the base fence.
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
>
> index d5db818f1c76..971ad97a2f54 100644
>
> --- a/drivers/gpu/drm/drm_syncobj.c
>
> +++ b/drivers/gpu/drm/drm_syncobj.c
>
> @@ -887,6 +887,7 @@ static int drm_syncobj_flatten_chain(struct 
> dma_fence **f)
>
>                 goto free_fences;
>
>         dma_fence_put(*f);
>
> + dma_fence_enable_sw_signaling(&array->base);
>
>         *f = array->fences[0];
>
>         return 0;
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
index d5db818f1c76..971ad97a2f54 100644
--- a/drivers/gpu/drm/drm_syncobj.c
+++ b/drivers/gpu/drm/drm_syncobj.c
@@ -887,6 +887,7 @@  static int drm_syncobj_flatten_chain(struct dma_fence **f)
                goto free_fences;

        dma_fence_put(*f);
+       dma_fence_enable_sw_signaling(&array->base);
        *f = array->fences[0];
        return 0;