From patchwork Tue Nov 27 11:50:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Xiao X-Patchwork-Id: 10702075 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0B72917D5 for ; Wed, 28 Nov 2018 08:43:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F0B832CDC9 for ; Wed, 28 Nov 2018 08:43:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E4E982CDF7; Wed, 28 Nov 2018 08:43:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=2.0 tests=BAYES_00,FORGED_HOTMAIL_RCVD2, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 669FD2CE09 for ; Wed, 28 Nov 2018 08:43:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6A43C89C93; Wed, 28 Nov 2018 08:43:27 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-oln040092253090.outbound.protection.outlook.com [40.92.253.90]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B1F96E089; Tue, 27 Nov 2018 11:50:21 +0000 (UTC) Received: from PU1APC01FT014.eop-APC01.prod.protection.outlook.com (10.152.252.51) by PU1APC01HT155.eop-APC01.prod.protection.outlook.com (10.152.252.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1339.10; Tue, 27 Nov 2018 11:50:17 +0000 Received: from HK0PR01MB2163.apcprd01.prod.exchangelabs.com (10.152.252.55) by PU1APC01FT014.mail.protection.outlook.com (10.152.252.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1339.10 via Frontend Transport; Tue, 27 Nov 2018 11:50:17 +0000 Received: from HK0PR01MB2163.apcprd01.prod.exchangelabs.com ([fe80::198d:1315:c7f3:abdb]) by HK0PR01MB2163.apcprd01.prod.exchangelabs.com ([fe80::198d:1315:c7f3:abdb%2]) with mapi id 15.20.1361.019; Tue, 27 Nov 2018 11:50:17 +0000 From: Yang Xiao To: "alexander.deucher@amd.com" , "christian.koenig@amd.com" , "David1.Zhou@amd.com" , "airlied@linux.ie" Subject: [PATCH] drm: radeon: fix overflow on 32bit systems Thread-Topic: [PATCH] drm: radeon: fix overflow on 32bit systems Thread-Index: AQHUhkdd+RLJK8IPf063QQsqIWkFlw== Date: Tue, 27 Nov 2018 11:50:17 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2P15301CA0024.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::34) To HK0PR01MB2163.apcprd01.prod.exchangelabs.com (2603:1096:203:73::11) x-incomingtopheadermarker: OriginalChecksum:FB622CE965BEBBE3AE835417A053E76A835941B04E1FF89A1642C322B521CA8B; UpperCasedChecksum:172B8BBE2057E7650A4A25B07E16D0C1B73A366F58F97440247A964468F8B858; SizeAsReceived:7657; Count:48 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [V+I4CkuMuhnXM3F4kE08RjRAGtqwv6+qd5j0brOliTM=] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; PU1APC01HT155; 6:dBYG/+4YRbnELEmLNMVkk5w3LKIwWUU4NX+IQDxaE4pWUzGEoE4xiL47LHTnvr6ip3zvAn7LKHClKlFaEjUo9+Ta2gka6zwAOrqNTiVy5DmO87UwsLXvoyf3AVyE7l0QeeA9EQLzk/ETEbJtDOe4fUiUAwC9wFoq5zA+nQLzHiG61g5RFO6TK1ZwK7T7bRTYhqcsJFr8jZGBNebro++ufhmplRK1L90NDx8DOrLo+leM28ZWXY5WiLrvAqarg7edY9P+3xaGxgz+OB4ObNbF4kXqwA5Ht/ips1rodVYi1bpZuuxSDJZ0QG2ftzjloHn5Le/g0589nH8U2lhq+jaLXQaI8ZQbXbhMqD73ee/sPBxFwIFu/f62J28yj9X4MVNjbcpWdqrL6HkPnJ4dSYyCswPfaxfSqH9Uy4hGO/7UccJ9vFj/kGKieFL+aBsSwJa4steTSHfRuqVYDLTal+FUZw==; 5:90zI3MRGWtOiPvxqntyf3fWrdAs30ko/30tQW6pC4qsmFIuG7fkGG34nAKUkBQ3Dow6RDvGEQ57sL9d52Sm5zGUVmZO9DULeQcNJntyA9WXJ1wvBfRnw33LX8Q3w54Jfq4Yi9HeUJ0x4UQiWQDpzLsClnbPebuf3RqCKr/kT+QU=; 7:qY1Ats8/XwfJNJJ1b2fRX5ST5MJteYnd9Za0K6ykzUewteKau62XPgwWdhc/6SK+vTB1RLA435mNtV8WzWtWoFiC8g9ROht2AlT0Uu9EFikGSo7Rf8F0A94eGw8W8nNxij2jZFukc33YW1tlzo4OeQ== x-incomingheadercount: 48 x-eopattributedmessage: 0 x-ms-exchange-slblob-mailprops: zswcL9HXbeVzbp1MTNnvF9uQdzYRBP5n11tuWAk/eVyCZbdf+st4BvkMT7gcLvAQsVG6Lg/dMrLys9pPYbJ/4a8hsx4JWrUKKAC19RGD6q9HoJ0/k/wKFE/vispx2ZN0RFiS23IChEbJXv2aip2Vr6K/nxdsotkBmARirkCR3ZkOX256zeSDvE4zL+7dVuJUp934DgHpOAZCo2uuyYcPD6QQR5vwHq3yj8yrlMNoPEdV3TbrgPSAQl6bBink/U7EjwHjSIVLNQtuvLmxd7gD3m+qDOjmXYxqthhgNwKuYXeX5ynD/OBfEt5lvzSWQiO1+D/RDxz54JarVaJ3/PPxlsDFJJdlMRyWZxqCRnIoECB6V9FYxsmDL9D0rxs2pNtz2N705GSjJI8IrcQTQDyUmC3eN/9vEzSVVR43QlIUaDsFaT5qjX6vYq4f2TOSzNR8UkRW5XVxcxw6p4iGS5acU4JczPDeMt9U2JHWb9tPfjEXn8COIyVqRZkBny0wlneWi87NLBQRP2fYXf74DwSDqsooc5+sh3r3yUZIndz6rz6odlwwDniCXltWn1khmo/+XU/0u44eleAuGeOQ0CDseYrLqS7Q/dOv4HrAWN1sX+j46E3KzAXcUx6V4vFXXYQw7JcREF8OnfscPbJk02v3r8auU7PJooTNZF+zY4ob3a7zFooTe2it7xFc4IwaZO+YhJKxkLNN3RqTu1WkeEX0Jpp4Q43a7Mdt9j7leJesv72ZFfgxpZc1ZLRGle0IScl7 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(201702181274)(2017031322404)(1603101475)(1601125500)(1701031045); SRVR:PU1APC01HT155; x-ms-traffictypediagnostic: PU1APC01HT155: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(4566010)(82015058); SRVR:PU1APC01HT155; BCL:0; PCL:0; RULEID:; SRVR:PU1APC01HT155; x-microsoft-antispam-message-info: gTDnMcw4vqk8Tdny7vehSfNk5qFc8CFp4Q/qVf4uVRuJpv9h6GAA1pSQ5i5SGz+R MIME-Version: 1.0 X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: c001924d-3e68-4f40-89c2-901a49278da7 X-MS-Exchange-CrossTenant-Network-Message-Id: 02eb67d4-11c6-484d-ecc6-08d6545e800b X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: c001924d-3e68-4f40-89c2-901a49278da7 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Nov 2018 11:50:17.4600 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: PU1APC01HT155 X-Mailman-Approved-At: Wed, 28 Nov 2018 08:42:26 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yang Xiao , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Young Xiao the type mem->start is unsigned long, so this can overflow on 32bit system, since the type addr is uint64_t. Signed-off-by: Young Xiao --- drivers/gpu/drm/radeon/radeon_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c index 7f1a9c7..51559d8 100644 --- a/drivers/gpu/drm/radeon/radeon_vm.c +++ b/drivers/gpu/drm/radeon/radeon_vm.c @@ -946,7 +946,7 @@ int radeon_vm_bo_update(struct radeon_device *rdev, bo_va->flags &= ~RADEON_VM_PAGE_WRITEABLE; if (mem) { - addr = mem->start << PAGE_SHIFT; + addr = (u64)mem->start << PAGE_SHIFT; if (mem->mem_type != TTM_PL_SYSTEM) { bo_va->flags |= RADEON_VM_PAGE_VALID; }