From patchwork Wed Nov 28 02:02:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Xiao X-Patchwork-Id: 10702069 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D0E95109C for ; Wed, 28 Nov 2018 08:42:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C35FE2CDB6 for ; Wed, 28 Nov 2018 08:42:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B764D2CE15; Wed, 28 Nov 2018 08:42:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=2.0 tests=BAYES_00,FORGED_HOTMAIL_RCVD2, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SUBJ_OBFU_PUNCT_FEW, SUBJ_OBFU_PUNCT_MANY autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 74F482CDCC for ; Wed, 28 Nov 2018 08:42:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 24E866E2BE; Wed, 28 Nov 2018 08:42:28 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from APC01-HK2-obe.outbound.protection.outlook.com (mail-oln040092255105.outbound.protection.outlook.com [40.92.255.105]) by gabe.freedesktop.org (Postfix) with ESMTPS id 271046E317; Wed, 28 Nov 2018 02:02:38 +0000 (UTC) Received: from HK2APC01FT042.eop-APC01.prod.protection.outlook.com (10.152.248.57) by HK2APC01HT114.eop-APC01.prod.protection.outlook.com (10.152.248.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1339.10; Wed, 28 Nov 2018 02:02:33 +0000 Received: from HK0PR01MB2163.apcprd01.prod.exchangelabs.com (10.152.248.59) by HK2APC01FT042.mail.protection.outlook.com (10.152.249.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1339.10 via Frontend Transport; Wed, 28 Nov 2018 02:02:33 +0000 Received: from HK0PR01MB2163.apcprd01.prod.exchangelabs.com ([fe80::198d:1315:c7f3:abdb]) by HK0PR01MB2163.apcprd01.prod.exchangelabs.com ([fe80::198d:1315:c7f3:abdb%2]) with mapi id 15.20.1361.019; Wed, 28 Nov 2018 02:02:33 +0000 From: Yang Xiao To: "harry.wentland@amd.com" , "sunpeng.li@amd.com" , "alexander.deucher@amd.com" , "christian.koenig@amd.com" , "David1.Zhou@amd.com" , "airlied@linux.ie" Subject: [PATCH] drm/amd/display: fix uninitialized symbol 'id' in bios_parser_get_src_obj Thread-Topic: [PATCH] drm/amd/display: fix uninitialized symbol 'id' in bios_parser_get_src_obj Thread-Index: AQHUhr5t9GFrOCRMk0aFfPESSAoUJg== Date: Wed, 28 Nov 2018 02:02:33 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR04CA0069.apcprd04.prod.outlook.com (2603:1096:202:15::13) To HK0PR01MB2163.apcprd01.prod.exchangelabs.com (2603:1096:203:73::11) x-incomingtopheadermarker: OriginalChecksum:C841AE9C181B4A7421B3FFCE34474083CEF3CAB13902C23CCC4B55D55E27B837; UpperCasedChecksum:03F185FD387BC1ED2B4F5D35781C4EA88F548BB2A3B537D36DC32388DC0DF61C; SizeAsReceived:7934; Count:48 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [atEkTgyciwhQwwLTjMmibdvniUi5gzyAp8gLT1Y1fIs=] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HK2APC01HT114; 6:iK/uAe21Lkycm9ZZGqi3gYQIFhwdYoG3j0D93ow7mDYMSXgvdifqpHal7qCw1tNfIhsAl3qQ1gn5DcLq70801x+MQHR7YC9d1GaBhJmdfyQfEo5055Hz8ejRwmMtV6adxdsVD/jDyhRxH+r/BAo7M2noXOJk1PvQu82meHLFCktroAt2g0/mK4ueF2fBJ5ZtR48EqhlagxCpaDfdQL1MS4C5KUiyqOtPoaZw9D/+I7Z2dNobaeiv8awIkMzrRsQR6xu3a1tx/svTbs6PAwNYW/MD01yRwY7AZwnq9qS02f/wfgdebtXaUmcuXKeXTpHhf8rTq10GhTaylyaaTPW6gEkivzu+xGpv05PajAA1+cNC4ohQ4TXJzE7BxHQs1jnLym7/6/i3Tz7xTyuIELsXcKrOuzJREbweGTGqhQofeh6bQQzR4eqbDmpnxDkDjnKNyM6+bviF1P4Zx2bwgVd/yw==; 5:tRLg845Jsp4dAjZru/NRKM2VmlGefuiC/10xeEfticVB59noKvLkUEQbrvgC6nWfgIrY8b6OJGLc4mAVcoPBUXqGFy5j/AsQf8a2daFFd9yRVtsvzFIeGV1qnv2vxXCJKP9uOuuFQQ9ntBVceZ3wNtmx6TeK/opoIalWHMDUkKg=; 7:j55tLnsEPI7xnikp1tjgWUzTkO46qGmDZYq4xa59lYpkaloVGetRAZicslOLVhjYaJOt43CUZ4S0D8SclESjtLbx0vyfOmA+rrVNJ2ym0zfxxTgGz22VFNrtslfb0lL/WlYbB/ZSgFcXU68Tb8Jsaw== x-incomingheadercount: 48 x-eopattributedmessage: 0 x-ms-exchange-slblob-mailprops: 7MJMDUNTCtzUteKnJBCTu1z2YExjfdiy4amZH13UE/CM+SYipkAgWlbFrYzHWknKpfYzrbccbwUXzrzYPaVl5u6Ywh1ys2bwV9ogh8uCgChyffMdxwM4KmcUrYJXId7cMEfzI9ZBTD1SdhbJNwr8uRbTMrArU2zJFtr4WQorm671YIMgEHlCkt2bdzNYYzz+PbFlDQlQjkcTGeoWsxsyVB+CntfdQdPbo26svvRu5T3JiZzFBWSkWCy/lRgrjAsEzyioqQtm5dCeXpmT8jjESq7+U/rLH9oKjfEG2kzwvx9wfB/rl078ts10iaB8NTOYh/6QfijLfZUL9DPpt+b2xUCA2XZvsM9i0jT7mHn2wWoqXPCIrUgHzEC2LtDiNVNvINRrpzsDMuF9uVFtlzyI2hp3vDy+6gB39LkxJTdgkXAU684hzy1SiekxiZoDxRZZ4EvVPmACjqLw4+BHmcevJV14qb+T+eJI4e+joroKZki5NzHPu294W2dMmVum7LZV17kTUDXdHdRMVww6ZBdRcG28MAEK1zkrUVIeb2VYC5cK9+I6Ea5eEa3RxlLLFrDB6rwO9pq6Hxv4uiDVXnFemRzqmN0OjX1Wz5ybcwNFu04DuiNCp3i4G+S3J54m5tKD5gexvQ2etjydUvdbVtqCmPwk+lGG9wNvxo9UGKxOtysBEfUV5ZIxsoq8U7Sjj7vQggt9XX3JlTL8JL0ZC+7wFTqO+72TayXAsKfHd/esvqI1Oay+YQ1oFw== x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(201702181274)(2017031322404)(1603101475)(1601125500)(1701031045); SRVR:HK2APC01HT114; x-ms-traffictypediagnostic: HK2APC01HT114: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(4566010)(82015058); SRVR:HK2APC01HT114; BCL:0; PCL:0; RULEID:; SRVR:HK2APC01HT114; x-microsoft-antispam-message-info: 2TLuE5n424QDGG4Rza7SWNNfQUtdK4c95jIAsTAKNF2C34IZNSbhS3XPT7Mao/AO MIME-Version: 1.0 X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: c001924d-3e68-4f40-89c2-901a49278da7 X-MS-Exchange-CrossTenant-Network-Message-Id: 50dde07f-9351-48e4-b4fe-08d654d58fca X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: c001924d-3e68-4f40-89c2-901a49278da7 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2018 02:02:33.9469 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT114 X-Mailman-Approved-At: Wed, 28 Nov 2018 08:42:26 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yang Xiao , "Bhawanpreet.Lakha@amd.com" , "Tony.Cheng@amd.com" , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Young Xiao See commit a8f976473196 ("drm/amd/display: Bunch of smatch error and warning fixes in DC") for detail. Signed-off-by: Young Xiao --- drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c index 0e1dc1b..6420546 100644 --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c @@ -188,7 +188,7 @@ static enum bp_result bios_parser_get_src_obj(struct dc_bios *dcb, struct graphics_object_id *src_object_id) { uint32_t number; - uint16_t *id; + uint16_t *id = NULL; ATOM_OBJECT *object; struct bios_parser *bp = BP_FROM_DCB(dcb); @@ -204,7 +204,7 @@ static enum bp_result bios_parser_get_src_obj(struct dc_bios *dcb, number = get_src_obj_list(bp, object, &id); - if (number <= index) + if (number <= index || !id) return BP_RESULT_BADINPUT; *src_object_id = object_id_from_bios_object_id(id[index]);