diff mbox series

[2/3] drm: clarify and linkify DRM_CLIENT_CAP_WRITEBACK_CONNECTORS docs

Message ID J47jNf2tAKjofhxL2LEdu1b3w1iRaisxtLCVObf9A@cp4-web-037.plabs.ch (mailing list archive)
State New, archived
Headers show
Series [1/3] drm: reference mode flags in DRM_CLIENT_CAP_* docs | expand

Commit Message

Simon Ser May 18, 2021, 11:14 a.m. UTC
Make it clear that the client is responsible for enabling ATOMIC
prior to enabling WRITEBACK_CONNECTORS. Linkify the reference to
ATOMIC.

Signed-off-by: Simon Ser <contact@emersion.fr>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Stone <daniels@collabora.com>
Cc: Pekka Paalanen <ppaalanen@gmail.com>
---
 include/uapi/drm/drm.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Pekka Paalanen May 20, 2021, 8:17 a.m. UTC | #1
On Tue, 18 May 2021 11:14:47 +0000
Simon Ser <contact@emersion.fr> wrote:

> Make it clear that the client is responsible for enabling ATOMIC
> prior to enabling WRITEBACK_CONNECTORS. Linkify the reference to
> ATOMIC.
> 
> Signed-off-by: Simon Ser <contact@emersion.fr>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Daniel Stone <daniels@collabora.com>
> Cc: Pekka Paalanen <ppaalanen@gmail.com>
> ---
>  include/uapi/drm/drm.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h
> index 1c947227f72b..87878aea4526 100644
> --- a/include/uapi/drm/drm.h
> +++ b/include/uapi/drm/drm.h
> @@ -812,8 +812,8 @@ struct drm_get_cap {
>   * DRM_CLIENT_CAP_WRITEBACK_CONNECTORS
>   *
>   * If set to 1, the DRM core will expose special connectors to be used for
> - * writing back to memory the scene setup in the commit. Depends on client
> - * also supporting DRM_CLIENT_CAP_ATOMIC
> + * writing back to memory the scene setup in the commit. The client must enable
> + * &DRM_CLIENT_CAP_ATOMIC first.
>   */
>  #define DRM_CLIENT_CAP_WRITEBACK_CONNECTORS	5
>  

I'll take your word that this is how it must be done.

Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com>


Thanks,
pq
diff mbox series

Patch

diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h
index 1c947227f72b..87878aea4526 100644
--- a/include/uapi/drm/drm.h
+++ b/include/uapi/drm/drm.h
@@ -812,8 +812,8 @@  struct drm_get_cap {
  * DRM_CLIENT_CAP_WRITEBACK_CONNECTORS
  *
  * If set to 1, the DRM core will expose special connectors to be used for
- * writing back to memory the scene setup in the commit. Depends on client
- * also supporting DRM_CLIENT_CAP_ATOMIC
+ * writing back to memory the scene setup in the commit. The client must enable
+ * &DRM_CLIENT_CAP_ATOMIC first.
  */
 #define DRM_CLIENT_CAP_WRITEBACK_CONNECTORS	5