From patchwork Mon Feb 5 02:53:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "He, Hongbo" X-Patchwork-Id: 10199819 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 640726056F for ; Mon, 5 Feb 2018 02:53:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 44E8C26E56 for ; Mon, 5 Feb 2018 02:53:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 37D4326E7B; Mon, 5 Feb 2018 02:53:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 43A3C26E56 for ; Mon, 5 Feb 2018 02:53:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE2A86E085; Mon, 5 Feb 2018 02:53:23 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0057.outbound.protection.outlook.com [104.47.34.57]) by gabe.freedesktop.org (Postfix) with ESMTPS id 520F66E077; Mon, 5 Feb 2018 02:53:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uJUEIBWKeN7igbsYs7htWzhsroLOkMPSHc/3OU0H9oQ=; b=C4/myXHgAIH8ZpYqSlaThd5R5ZuAHVnbyfKGIAeNalDcLEm3W5toDhhlAEMfOy9FT6ADS2s2xXGXnD/odhNeNS4eHks99FuhfXkPjKHz8u5pyHBHOsmYuUQnI9JEEzVVYRQOkjthHvE7nHt3Ot2Luqc0kP4kMB69LzvOyNJR8q4= Received: from MWHPR1201MB0127.namprd12.prod.outlook.com (10.174.98.142) by MWHPR1201MB0031.namprd12.prod.outlook.com (10.174.97.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Mon, 5 Feb 2018 02:53:20 +0000 Received: from MWHPR1201MB0127.namprd12.prod.outlook.com ([10.174.98.142]) by MWHPR1201MB0127.namprd12.prod.outlook.com ([10.174.98.142]) with mapi id 15.20.0464.015; Mon, 5 Feb 2018 02:53:20 +0000 From: "He, Roger" To: =?utf-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" Subject: RE: [PATCH 3/5] drm/radeon: remove extra TT unpopulated check Thread-Topic: [PATCH 3/5] drm/radeon: remove extra TT unpopulated check Thread-Index: AQHTnFlsJkyb+p6KikGrNdRMAEF996OVH3Mw Date: Mon, 5 Feb 2018 02:53:19 +0000 Message-ID: References: <20180202190948.2654-1-christian.koenig@amd.com> <20180202190948.2654-3-christian.koenig@amd.com> In-Reply-To: <20180202190948.2654-3-christian.koenig@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Hongbo.He@amd.com; x-originating-ip: [116.228.147.241] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MWHPR1201MB0031; 20:M537Ts8r/7omwFx+/kQ0hhIUvrwXIlzDe8OcfdHvMZPoWE9yVAiXE9di2QhfhmX0cV1AXHUIiG90Ip6wP1hrh2PQsMRtH/TIkGIP7DL5zIr+Y5KcDBknxrmWr6GfKhb6iDSSmKANC/qNu1B5clsJbYg9CBINa4snJBC4Jj2I9UyMYflhd9rD7GuStDtTOt1a58lne/OsPUNE9Vf3ARXasZ7bCk6syN58YbPb4Y8nfiSwadRM3zXMda8dUvkgayrp x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3fea46c5-1edd-4f92-3775-08d56c439d7d x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:MWHPR1201MB0031; x-ms-traffictypediagnostic: MWHPR1201MB0031: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(767451399110)(217544274631240); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231101)(2400082)(944501161)(93006095)(93001095)(6055026)(6041288)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:MWHPR1201MB0031; BCL:0; PCL:0; RULEID:; SRVR:MWHPR1201MB0031; x-forefront-prvs: 0574D4712B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39380400002)(346002)(376002)(39860400002)(396003)(13464003)(189003)(199004)(106356001)(74316002)(86362001)(6436002)(7736002)(2501003)(305945005)(3280700002)(2201001)(105586002)(66066001)(53936002)(2900100001)(575784001)(55016002)(9686003)(6246003)(39060400002)(102836004)(14454004)(99286004)(8676002)(966005)(68736007)(6306002)(186003)(26005)(81166006)(53546011)(77096007)(6506007)(97736004)(72206003)(81156014)(76176011)(478600001)(5660300001)(3846002)(8936002)(6116002)(7696005)(2906002)(229853002)(110136005)(33656002)(316002)(25786009)(2950100002)(3660700001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR1201MB0031; H:MWHPR1201MB0127.namprd12.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: qqiVq8VDt1lFOhS9V3WhHj7bKx0L1UZfEkrLKxkG7onrecRLm3DPNZEnrzoHA7bnN9S+haBsKJ69MPgXZ44Uiw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fea46c5-1edd-4f92-3775-08d56c439d7d X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2018 02:53:20.0037 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0031 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP -----Original Message----- From: dri-devel [mailto:dri-devel-bounces@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Saturday, February 03, 2018 3:10 AM To: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: [PATCH 3/5] drm/radeon: remove extra TT unpopulated check The subsystem chould check that, not the driver. Commit log typo, should be "should" rather than " chould". With that fix, this patch is Reviewed-by: Roger He Thanks Roger(Hongbo.He) Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_ttm.c | 3 --- 1 file changed, 3 deletions(-) -- 2.14.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index a0a839bc39bf..42e3ee81a96e 100644 --- a/drivers/gpu/drm/radeon/radeon_ttm.c +++ b/drivers/gpu/drm/radeon/radeon_ttm.c @@ -728,9 +728,6 @@ static int radeon_ttm_tt_populate(struct ttm_tt *ttm, struct radeon_device *rdev; bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG); - if (ttm->state != tt_unpopulated) - return 0; - if (gtt && gtt->userptr) { ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL); if (!ttm->sg)