Message ID | MWHPR12MB1694DF65C8C3F26DC1F33312FBD10@MWHPR12MB1694.namprd12.prod.outlook.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <dri-devel-bounces@lists.freedesktop.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5CCA16038F for <patchwork-dri-devel@patchwork.kernel.org>; Wed, 14 Mar 2018 11:52:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4ACD0286C8 for <patchwork-dri-devel@patchwork.kernel.org>; Wed, 14 Mar 2018 11:52:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3F2F3286F5; Wed, 14 Mar 2018 11:52:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, HTML_MESSAGE, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7EEFC286C8 for <patchwork-dri-devel@patchwork.kernel.org>; Wed, 14 Mar 2018 11:52:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7EB806E13C; Wed, 14 Mar 2018 11:52:31 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0040.outbound.protection.outlook.com [104.47.40.40]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40C2B6E0ED; Wed, 14 Mar 2018 11:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=laoDjzNsstqN3fY4jzGMngvyZkmSe1tw0xxbskh5Cms=; b=0WT24DOjSqypRly4gmIzhwhQ7I7lZ+RXfwuR+JQ92ASSUC/3dEZuPTmHbkexSbK52YUYdFDlFMGzrptWZPsGuICooX8YgJcl2NBFmOxU6OEqR4+tRv6rVxxj+v30dEmmxz6kOTJdrVZ0IwVLgfzhdqkzysuJILBxjGnaJRz+bgw= Received: from MWHPR12MB1694.namprd12.prod.outlook.com (10.172.56.146) by MWHPR12MB1822.namprd12.prod.outlook.com (10.175.55.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.567.14; Wed, 14 Mar 2018 11:52:28 +0000 Received: from MWHPR12MB1694.namprd12.prod.outlook.com ([fe80::799b:618b:45a4:9e56]) by MWHPR12MB1694.namprd12.prod.outlook.com ([fe80::799b:618b:45a4:9e56%17]) with mapi id 15.20.0548.021; Wed, 14 Mar 2018 11:52:26 +0000 From: "Zhu, Rex" <Rex.Zhu@amd.com> To: Colin King <colin.king@canonical.com>, "Deucher, Alexander" <Alexander.Deucher@amd.com>, "Koenig, Christian" <Christian.Koenig@amd.com>, "Zhou, David(ChunMing)" <David1.Zhou@amd.com>, David Airlie <airlied@linux.ie>, "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org> Subject: Re: [PATCH][next] drm/amd/pp: remove redundant pointer internal_buf Thread-Topic: [PATCH][next] drm/amd/pp: remove redundant pointer internal_buf Thread-Index: AQHTus5SqNPEoXeHt02PLp3ijc78KKPPoBo2 Date: Wed, 14 Mar 2018 11:52:26 +0000 Message-ID: <MWHPR12MB1694DF65C8C3F26DC1F33312FBD10@MWHPR12MB1694.namprd12.prod.outlook.com> References: <20180313132217.31025-1-colin.king@canonical.com> In-Reply-To: <20180313132217.31025-1-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rex.Zhu@amd.com; x-originating-ip: [116.228.147.241] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MWHPR12MB1822; 7:Yqrh1MdjwNccxFt+5Wsvt87sV6fXPsDiK9bD6EQQwwXBLK4XbxtJaH7Z5yTn8wCupoy6gKa+myg8e6fEuJMcjqyesRZlmmREzK431X7B5o1giedv4+MnTVljgr2KDaOxzo7QBHX0F1SnD3Ol6XmxgasjFRHbzNis4AfF8xvU95SUQ/AmzhwbpEe2scqYp43ja6PNVcxqPVtTm9XRrGQE/Ya15lvo2JGF2Awo7B6NAhGCjLaHDe5qy7km/hJSZrnp; 20:Eo0j6ozUwxDhqjh8JTQv1aXjpTZzoOIU8sd+81+zCfoIrbiR9WUPzJsQczqNwIXkZAxl27lCnfH7w8dJv0SbiDCVwfMhSnIekPZUKfp0iaNuwZh9j4G/oa4vxmvyI5pD6YDbj6KQ66g7erZ5nG3K9uN/dhj1/M89luv3DBLxujBGMQ2QcRF8P0RPNznSCcJejavQXwx15H9/1CP+Sfv46JQHkv/fSTjSg+q1YUM4JLOvCd3cDYFhUjzfITA1YXoi x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(39860400002)(366004)(39380400002)(396003)(346002)(376002)(199004)(189003)(105586002)(33656002)(3660700001)(2201001)(2906002)(54906003)(110136005)(2950100002)(6606003)(81166006)(316002)(5250100002)(8676002)(66066001)(229853002)(68736007)(5660300001)(81156014)(8936002)(2501003)(86362001)(3846002)(19627405001)(3280700002)(59450400001)(102836004)(53546011)(26005)(186003)(6436002)(14454004)(76176011)(6506007)(6116002)(74316002)(7736002)(6246003)(2900100001)(55016002)(72206003)(53936002)(4326008)(54896002)(9686003)(106356001)(99286004)(97736004)(7696005)(25786009)(478600001)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR12MB1822; H:MWHPR12MB1694.namprd12.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e0cd0f26-8412-4587-436b-08d589a20edc x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:MWHPR12MB1822; x-ms-traffictypediagnostic: MWHPR12MB1822: x-microsoft-antispam-prvs: <MWHPR12MB18220BA28EC246FB3C01BD8FFBD10@MWHPR12MB1822.namprd12.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(9452136761055)(217544274631240)(198206253151910); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501244)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:MWHPR12MB1822; BCL:0; PCL:0; RULEID:; SRVR:MWHPR12MB1822; x-forefront-prvs: 0611A21987 received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 3FOdJK3fJnL3NnoVsFeMTZd+XlUpthltMNIeQiITXNZdfsuum3ar+a+R0X+t6YYXSYsQDsiKnAEnJG2CViiNzWqb/cdo0/wO6zzjWZHCQ9xVZ8PZLAaQTe+IqRYbNvILG9xcOSVUaYJOormSX1XPHDNMQBqbnviDZj+itPqct0gZAnTrVfAnHOcJOz2fNWvHOANKvPIeSOo3MLHrnfkYamkKJHTonEIm5Iy7sxuJdDIxws5mLp8VRFSQKvo0bldnJKxadgul7bb9+Os4rSn12X0zVXFeHGMB96hcgwq8dEsav/DPnBtqwnh4GhOB7fKorlJn99dNNn1Qkv5fqlurJQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0cd0f26-8412-4587-436b-08d589a20edc X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2018 11:52:26.5129 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1822 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development <dri-devel.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>, <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/dri-devel> List-Post: <mailto:dri-devel@lists.freedesktop.org> List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>, <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe> Cc: "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Content-Type: multipart/mixed; boundary="===============1891796260==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org> X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c index 7394bb46b8b2..dcb151cabc00 100644 --- a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c @@ -585,7 +585,6 @@ int smu7_setup_pwr_virus(struct pp_hwmgr *hwmgr) int smu7_init(struct pp_hwmgr *hwmgr) { struct smu7_smumgr *smu_data; - uint8_t *internal_buf; uint64_t mc_addr = 0; int r; /* Allocate memory for backend private data */ @@ -627,7 +626,6 @@ int smu7_init(struct pp_hwmgr *hwmgr) &smu_data->header_buffer.kaddr); return -EINVAL; } - internal_buf = smu_data->smu_buffer.kaddr; smu_data->smu_buffer.mc_addr = mc_addr; if (smum_is_hw_avfs_present(hwmgr))