[RESEND] drm/gma500: Fix comments in gtt.c

Commit Message

Jiang Biao Aug. 10, 2016, 3:35 a.m. UTC

Fix some comment faults in gtt.c.

Signed-off-by: Jiang Biao <[e-mail]>
---
 drivers/gpu/drm/gma500/gtt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--
2.1.0

Comments

Daniel Vetter Aug. 10, 2016, 8:35 a.m. UTC | #1

On Wed, Aug 10, 2016 at 11:35:14AM +0800, [e-mail] wrote:
> 
> Fix some comment faults in gtt.c.
> 
> Signed-off-by: Jiang Biao <[e-mail]>

Sending the same patch 3 times in just one hour doesn't help - people
sometimes sleep, or are busy. Please let at least a few days pass until
you ping (with a reply) or resend.

Thanks, Daniel

> ---
>  drivers/gpu/drm/gma500/gtt.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/gma500/gtt.c b/drivers/gpu/drm/gma500/gtt.c
> index 8f69225..9f9f588 100644
> --- a/drivers/gpu/drm/gma500/gtt.c
> +++ b/drivers/gpu/drm/gma500/gtt.c
> @@ -76,6 +76,7 @@ static u32 __iomem *psb_gtt_entry(struct drm_device *dev, struct gtt_range *r)
>   *	psb_gtt_insert	-	put an object into the GTT
>   *	@dev: our DRM device
>   *	@r: our GTT range
> + *	@resume: on resume
>   *
>   *	Take our preallocated GTT range and insert the GEM object into
>   *	the GTT. This is protected via the gtt mutex which the caller
> @@ -321,6 +322,7 @@ out:
>   *	@len: length (bytes) of address space required
>   *	@name: resource name
>   *	@backed: resource should be backed by stolen pages
> + *	@align: requested alignment
>   *
>   *	Ask the kernel core to find us a suitable range of addresses
>   *	to use for a GTT mapping.
> @@ -440,7 +442,6 @@ int psb_gtt_init(struct drm_device *dev, int resume)
>  	PSB_WVDC32(dev_priv->pge_ctl | _PSB_PGETBL_ENABLED, PSB_PGETBL_CTL);
>  	(void) PSB_RVDC32(PSB_PGETBL_CTL);
> 
> -	/* The root resource we allocate address space from */
>  	dev_priv->gtt_initialized = 1;
> 
>  	pg->gtt_phys_start = dev_priv->pge_ctl & PAGE_MASK;
> --
> 2.1.0
> 
> _______________________________________________
> dri-devel mailing list
> [e-mail]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Jiang Biao Aug. 10, 2016, 8:52 a.m. UTC | #2

Daniel Vetter <[e-mail]> wrote on 2016/08/10 16:35:29:

> Daniel Vetter <[e-mail]>
> From: Daniel Vetter <[e-mail]>
>
> 2016/08/10 16:35
>
>
> [e-mail],
>
>
> Re: [RESEND PATCH] drm/gma500: Fix comments in gtt.c
>
> On Wed, Aug 10, 2016 at 11:35:14AM +0800, [e-mail] wrote:
> >
> > Fix some comment faults in gtt.c.
> >
> > Signed-off-by: Jiang Biao <[e-mail]>
>
> Sending the same patch 3 times in just one hour doesn't help - people
> sometimes sleep, or are busy. Please let at least a few days pass until
> you ping (with a reply) or resend.
>
> Thanks, Daniel
>
I'm so sorry about the interruption.
The mail server of my company corrupted the format of first two patchs,
and I have to resend it with correct format, after I corrected the
configuration of the mail server. The format of the last one should be
right.
I'm fresh to this mailing list, next time should be right.
Thanks a lot.

Daniel Vetter Aug. 10, 2016, 9:22 a.m. UTC | #3

On Wed, Aug 10, 2016 at 04:52:53PM +0800, [e-mail] wrote:
> 
> 
> Daniel Vetter <[e-mail]> wrote on 2016/08/10 16:35:29:
> 
> > Daniel Vetter <[e-mail]>
> > From: Daniel Vetter <[e-mail]>
> >
> > 2016/08/10 16:35
> >
> >
> > [e-mail],
> >
> >
> > Re: [RESEND PATCH] drm/gma500: Fix comments in gtt.c
> >
> > On Wed, Aug 10, 2016 at 11:35:14AM +0800, [e-mail] wrote:
> > >
> > > Fix some comment faults in gtt.c.
> > >
> > > Signed-off-by: Jiang Biao <[e-mail]>
> >
> > Sending the same patch 3 times in just one hour doesn't help - people
> > sometimes sleep, or are busy. Please let at least a few days pass until
> > you ping (with a reply) or resend.
> >
> > Thanks, Daniel
> >
> I'm so sorry about the interruption.
> The mail server of my company corrupted the format of first two patchs,
> and I have to resend it with correct format, after I corrected the
> configuration of the mail server. The format of the last one should be
> right.
> I'm fresh to this mailing list, next time should be right.
> Thanks a lot.

Ah now worries. In such a case simply add a small comment to your resend
patches why you're resending. You can add such comments to the commit
message at the and after a line with just --- git will then cut it away.
E.g.

... commmit message ...

Signed-off-by: Daniel Vetter <[e-mail]>
---
This here is an additional comment which will not get applied to the real
git log.

Making sure that the patch isn't corrupted is definitely appreciated!
-Daniel

Jiang Biao Aug. 11, 2016, 12:45 a.m. UTC | #4

Daniel Vetter <[e-mail]> wrote on 2016/08/10 17:22:14:

> Daniel Vetter <[e-mail]>
> From:  Daniel Vetter <[e-mail]>
> 2016/08/10 17:22
>
> To: [e-mail],
>
> Re: [RESEND PATCH] drm/gma500: Fix comments in gtt.c
>
> On Wed, Aug 10, 2016 at 04:52:53PM +0800, [e-mail] wrote:
> >
> >
> > Daniel Vetter <[e-mail]> wrote on 2016/08/10 16:35:29:
> >
> > > Daniel Vetter <[e-mail]>
> > > From: Daniel Vetter <[e-mail]>
> > >
> > > 2016/08/10 16:35
> > >
> > >
> > > [e-mail],
> > >
> > >
> > > Re: [RESEND PATCH] drm/gma500: Fix comments in gtt.c
> > >
> > > On Wed, Aug 10, 2016 at 11:35:14AM +0800, [e-mail] wrote:
> > > >
> > > > Fix some comment faults in gtt.c.
> > > >
> > > > Signed-off-by: Jiang Biao <[e-mail]>
> > >
> > > Sending the same patch 3 times in just one hour doesn't help - people
> > > sometimes sleep, or are busy. Please let at least a few days pass until
> > > you ping (with a reply) or resend.
> > >
> > > Thanks, Daniel
> > >
> > I'm so sorry about the interruption.
> > The mail server of my company corrupted the format of first two patchs,
> > and I have to resend it with correct format, after I corrected the
> > configuration of the mail server. The format of the last one should be
> > right.
> > I'm fresh to this mailing list, next time should be right.
> > Thanks a lot.
>
> Ah now worries. In such a case simply add a small comment to your resend
> patches why you're resending. You can add such comments to the commit
> message at the and after a line with just --- git will then cut it away.
> E.g.
>
> ... commmit message ...
>
> Signed-off-by: Daniel Vetter <[e-mail]>
> ---
> This here is an additional comment which will not get applied to the real
> git log.
>
> Making sure that the patch isn't corrupted is definitely appreciated!
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

Actually, as newcomer, I didn't exactly know how to resend a patch in this
case. Thank you very much for your guidance, that's very helpful for me.

What I want is just to make my contribution, hope to communicate with you
more often.

Next time will be better. Thanks again.

Patch

diff --git a/drivers/gpu/drm/gma500/gtt.c b/drivers/gpu/drm/gma500/gtt.c
index 8f69225..9f9f588 100644
--- a/drivers/gpu/drm/gma500/gtt.c
+++ b/drivers/gpu/drm/gma500/gtt.c
@@ -76,6 +76,7 @@  static u32 __iomem *psb_gtt_entry(struct drm_device *dev, struct gtt_range *r)
  *	psb_gtt_insert	-	put an object into the GTT
  *	@dev: our DRM device
  *	@r: our GTT range
+ *	@resume: on resume
  *
  *	Take our preallocated GTT range and insert the GEM object into
  *	the GTT. This is protected via the gtt mutex which the caller
@@ -321,6 +322,7 @@  out:
  *	@len: length (bytes) of address space required
  *	@name: resource name
  *	@backed: resource should be backed by stolen pages
+ *	@align: requested alignment
  *
  *	Ask the kernel core to find us a suitable range of addresses
  *	to use for a GTT mapping.
@@ -440,7 +442,6 @@  int psb_gtt_init(struct drm_device *dev, int resume)
 	PSB_WVDC32(dev_priv->pge_ctl | _PSB_PGETBL_ENABLED, PSB_PGETBL_CTL);
 	(void) PSB_RVDC32(PSB_PGETBL_CTL);

-	/* The root resource we allocate address space from */
 	dev_priv->gtt_initialized = 1;

 	pg->gtt_phys_start = dev_priv->pge_ctl & PAGE_MASK;