Message ID | SN6PR06MB5342F273F5DAA0DD24E89EA3A5849@SN6PR06MB5342.namprd06.prod.outlook.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers | show |
Series | drm/panel: elida-kd35t133: allow using non-continuous dsi clock | expand |
On Fri, 19 Feb 2021 at 00:14, Chris Morgan <macromorgan@hotmail.com> wrote: > > This fixes an issue with the panel not working after > commit c6d94e37bdbb ("drm/bridge/synopsys: dsi: add support for non-continuous HS clock"). > With this change the panel inits successfully and displays an image. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-elida-kd35t133.c b/drivers/gpu/drm/panel/panel-elida-kd35t133.c > index bc36aa3c1123..fe5ac3ef9018 100644 > --- a/drivers/gpu/drm/panel/panel-elida-kd35t133.c > +++ b/drivers/gpu/drm/panel/panel-elida-kd35t133.c > @@ -265,7 +265,8 @@ static int kd35t133_probe(struct mipi_dsi_device *dsi) > dsi->lanes = 1; > dsi->format = MIPI_DSI_FMT_RGB888; > dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | > - MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_EOT_PACKET; > + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_EOT_PACKET | > + MIPI_DSI_CLOCK_NON_CONTINUOUS; > > drm_panel_init(&ctx->panel, &dsi->dev, &kd35t133_funcs, > DRM_MODE_CONNECTOR_DSI); > -- > 2.25.1 > I kindly appreciate you taking the time to debug this one. It looks good, but also seems like Heiko already sent the same fix: https://www.spinics.net/lists/kernel/msg3824932.html Thanks, Eze
Yes, I just spoke with him via email. I can confirm his fix/my fix/whichever fix solves the issue on the latest 5.11 kernel. From: Ezequiel Garcia<mailto:ezequiel@vanguardiasur.com.ar> Sent: Friday, February 19, 2021 10:00 AM To: Chris Morgan<mailto:macromorgan@hotmail.com> Cc: tzimmermann@suse.de<mailto:tzimmermann@suse.de>; Thierry Reding<mailto:thierry.reding@gmail.com>; Sam Ravnborg<mailto:sam@ravnborg.org>; David Airlie<mailto:airlied@linux.ie>; Daniel Vetter<mailto:daniel@ffwll.ch>; dri-devel<mailto:dri-devel@lists.freedesktop.org>; Heiko Stuebner<mailto:heiko@sntech.de> Subject: Re: [PATCH] drm/panel: elida-kd35t133: allow using non-continuous dsi clock On Fri, 19 Feb 2021 at 00:14, Chris Morgan <macromorgan@hotmail.com> wrote: > > This fixes an issue with the panel not working after > commit c6d94e37bdbb ("drm/bridge/synopsys: dsi: add support for non-continuous HS clock"). > With this change the panel inits successfully and displays an image. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-elida-kd35t133.c b/drivers/gpu/drm/panel/panel-elida-kd35t133.c > index bc36aa3c1123..fe5ac3ef9018 100644 > --- a/drivers/gpu/drm/panel/panel-elida-kd35t133.c > +++ b/drivers/gpu/drm/panel/panel-elida-kd35t133.c > @@ -265,7 +265,8 @@ static int kd35t133_probe(struct mipi_dsi_device *dsi) > dsi->lanes = 1; > dsi->format = MIPI_DSI_FMT_RGB888; > dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | > - MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_EOT_PACKET; > + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_EOT_PACKET | > + MIPI_DSI_CLOCK_NON_CONTINUOUS; > > drm_panel_init(&ctx->panel, &dsi->dev, &kd35t133_funcs, > DRM_MODE_CONNECTOR_DSI); > -- > 2.25.1 > I kindly appreciate you taking the time to debug this one. It looks good, but also seems like Heiko already sent the same fix: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.spinics.net%2Flists%2Fkernel%2Fmsg3824932.html&data=04%7C01%7C%7Cbdecc3cd75554c2ad3bb08d8d4ef7324%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637493472196595230%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=oBQtE63GEcbqIPxEtO%2BotZEaUnwrRD52OynUoBB%2FNp4%3D&reserved=0 Thanks, Eze
diff --git a/drivers/gpu/drm/panel/panel-elida-kd35t133.c b/drivers/gpu/drm/panel/panel-elida-kd35t133.c index bc36aa3c1123..fe5ac3ef9018 100644 --- a/drivers/gpu/drm/panel/panel-elida-kd35t133.c +++ b/drivers/gpu/drm/panel/panel-elida-kd35t133.c @@ -265,7 +265,8 @@ static int kd35t133_probe(struct mipi_dsi_device *dsi) dsi->lanes = 1; dsi->format = MIPI_DSI_FMT_RGB888; dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | - MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_EOT_PACKET; + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_EOT_PACKET | + MIPI_DSI_CLOCK_NON_CONTINUOUS; drm_panel_init(&ctx->panel, &dsi->dev, &kd35t133_funcs, DRM_MODE_CONNECTOR_DSI);
This fixes an issue with the panel not working after commit c6d94e37bdbb ("drm/bridge/synopsys: dsi: add support for non-continuous HS clock"). With this change the panel inits successfully and displays an image. Signed-off-by: Chris Morgan <macromorgan@hotmail.com> --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)