| Message ID | Y+YYZ4SbMQBcpTZP@ubun2204.myguest.virtualbox.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amd/display: Remove duplicate/repeating expression | expand |
On 2/10/23 05:11, Deepak R Varma wrote: > Remove duplicate or repeating expressions in the if condition > evaluation. Issue identified using doubletest.cocci Coccinelle semantic > patch. > > Signed-off-by: Deepak R Varma <drv@mailo.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Harry > --- > .../gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c > index 61ee9ba063a7..6576b897a512 100644 > --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c > +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c > @@ -51,7 +51,7 @@ static bool CalculateBytePerPixelAnd256BBlockSizes( > *BytePerPixelDETC = 0; > *BytePerPixelY = 4; > *BytePerPixelC = 0; > - } else if (SourcePixelFormat == dm_444_16 || SourcePixelFormat == dm_444_16) { > + } else if (SourcePixelFormat == dm_444_16) { > *BytePerPixelDETY = 2; > *BytePerPixelDETC = 0; > *BytePerPixelY = 2;
On Fri, Feb 10, 2023 at 10:22:00AM -0500, Harry Wentland wrote: > On 2/10/23 05:11, Deepak R Varma wrote: > > Remove duplicate or repeating expressions in the if condition > > evaluation. Issue identified using doubletest.cocci Coccinelle semantic > > patch. > > > > Signed-off-by: Deepak R Varma <drv@mailo.com> > > Reviewed-by: Harry Wentland <harry.wentland@amd.com> Thank you Harry. There is another similar patch I submitted for a different file. Could you please also review that and share your feedback? Thank you, ./drv > > Harry > > > --- > > .../gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c > > index 61ee9ba063a7..6576b897a512 100644 > > --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c > > +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c > > @@ -51,7 +51,7 @@ static bool CalculateBytePerPixelAnd256BBlockSizes( > > *BytePerPixelDETC = 0; > > *BytePerPixelY = 4; > > *BytePerPixelC = 0; > > - } else if (SourcePixelFormat == dm_444_16 || SourcePixelFormat == dm_444_16) { > > + } else if (SourcePixelFormat == dm_444_16) { > > *BytePerPixelDETY = 2; > > *BytePerPixelDETC = 0; > > *BytePerPixelY = 2; >
Applied. Thanks! On Fri, Feb 10, 2023 at 10:22 AM Harry Wentland <harry.wentland@amd.com> wrote: > > On 2/10/23 05:11, Deepak R Varma wrote: > > Remove duplicate or repeating expressions in the if condition > > evaluation. Issue identified using doubletest.cocci Coccinelle semantic > > patch. > > > > Signed-off-by: Deepak R Varma <drv@mailo.com> > > Reviewed-by: Harry Wentland <harry.wentland@amd.com> > > Harry > > > --- > > .../gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c > > index 61ee9ba063a7..6576b897a512 100644 > > --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c > > +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c > > @@ -51,7 +51,7 @@ static bool CalculateBytePerPixelAnd256BBlockSizes( > > *BytePerPixelDETC = 0; > > *BytePerPixelY = 4; > > *BytePerPixelC = 0; > > - } else if (SourcePixelFormat == dm_444_16 || SourcePixelFormat == dm_444_16) { > > + } else if (SourcePixelFormat == dm_444_16) { > > *BytePerPixelDETY = 2; > > *BytePerPixelDETC = 0; > > *BytePerPixelY = 2; >
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c index 61ee9ba063a7..6576b897a512 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c @@ -51,7 +51,7 @@ static bool CalculateBytePerPixelAnd256BBlockSizes( *BytePerPixelDETC = 0; *BytePerPixelY = 4; *BytePerPixelC = 0; - } else if (SourcePixelFormat == dm_444_16 || SourcePixelFormat == dm_444_16) { + } else if (SourcePixelFormat == dm_444_16) { *BytePerPixelDETY = 2; *BytePerPixelDETC = 0; *BytePerPixelY = 2;
Remove duplicate or repeating expressions in the if condition evaluation. Issue identified using doubletest.cocci Coccinelle semantic patch. Signed-off-by: Deepak R Varma <drv@mailo.com> --- .../gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)