| Message ID | Y3eCqQ2pm1uQnktV@kadam (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/msm/hdmi: remove unnecessary NULL check | expand |
On 11/18/2022 5:03 AM, Dan Carpenter wrote: > This code was recently refactored in commit and now the "hdmi" pointer > can't be NULL. Checking for NULL leads to a Smatch warning: > > drivers/gpu/drm/msm/hdmi/hdmi.c:141 msm_hdmi_init() > warn: variable dereferenced before check 'hdmi' (see line 119) > > Fixes: 69a88d8633ec ("drm/msm/hdmi: move resource allocation to probe function") > Signed-off-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > v2: Add a Fixes tag. Re-work the commit message. > > drivers/gpu/drm/msm/hdmi/hdmi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c > index 7001fabd0977..4d3fdc806bef 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c > @@ -138,8 +138,7 @@ static int msm_hdmi_init(struct hdmi *hdmi) > return 0; > > fail: > - if (hdmi) > - msm_hdmi_destroy(hdmi); > + msm_hdmi_destroy(hdmi); > > return ret; > }
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index 7001fabd0977..4d3fdc806bef 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c @@ -138,8 +138,7 @@ static int msm_hdmi_init(struct hdmi *hdmi) return 0; fail: - if (hdmi) - msm_hdmi_destroy(hdmi); + msm_hdmi_destroy(hdmi); return ret; }
This code was recently refactored in commit and now the "hdmi" pointer can't be NULL. Checking for NULL leads to a Smatch warning: drivers/gpu/drm/msm/hdmi/hdmi.c:141 msm_hdmi_init() warn: variable dereferenced before check 'hdmi' (see line 119) Fixes: 69a88d8633ec ("drm/msm/hdmi: move resource allocation to probe function") Signed-off-by: Dan Carpenter <error27@gmail.com> --- v2: Add a Fixes tag. Re-work the commit message. drivers/gpu/drm/msm/hdmi/hdmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)