Message ID | Y8AQYhVkJjV86VXV@ubun2204.myguest.virtualbox.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | drm/amd/display: Conversion to bool not necessary | expand |
Applied. Thanks! Alex On Thu, Jan 12, 2023 at 8:51 AM Deepak R Varma <drv@mailo.com> wrote: > > A logical evaluation already results in bool. There is no need for using > a ternary operator based evaluation and bool conversion of the outcome. > Issue identified using boolconv.cocci Coccinelle semantic patch. > This was also reported by the Kernel Test Robot. Hence > > Fixes: 473683a03495 ("drm/amd/display: Create a file dedicated for CRTC") > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Deepak R Varma <drv@mailo.com> > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c > index 22125daf9dcf..1e39d0939700 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c > @@ -105,8 +105,7 @@ static void vblank_control_worker(struct work_struct *work) > else if (dm->active_vblank_irq_count) > dm->active_vblank_irq_count--; > > - dc_allow_idle_optimizations( > - dm->dc, dm->active_vblank_irq_count == 0 ? true : false); > + dc_allow_idle_optimizations(dm->dc, dm->active_vblank_irq_count == 0); > > DRM_DEBUG_KMS("Allow idle optimizations (MALL): %d\n", dm->active_vblank_irq_count == 0); > > -- > 2.34.1 > > >
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c index 22125daf9dcf..1e39d0939700 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c @@ -105,8 +105,7 @@ static void vblank_control_worker(struct work_struct *work) else if (dm->active_vblank_irq_count) dm->active_vblank_irq_count--; - dc_allow_idle_optimizations( - dm->dc, dm->active_vblank_irq_count == 0 ? true : false); + dc_allow_idle_optimizations(dm->dc, dm->active_vblank_irq_count == 0); DRM_DEBUG_KMS("Allow idle optimizations (MALL): %d\n", dm->active_vblank_irq_count == 0);
A logical evaluation already results in bool. There is no need for using a ternary operator based evaluation and bool conversion of the outcome. Issue identified using boolconv.cocci Coccinelle semantic patch. This was also reported by the Kernel Test Robot. Hence Fixes: 473683a03495 ("drm/amd/display: Create a file dedicated for CRTC") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Deepak R Varma <drv@mailo.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)