| Message ID | YJ+ZgXTFa6voZuJG@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm: bridge: it66121: fix an error code in it66121_probe() | expand |
On 15/05/2021 11:50, Dan Carpenter wrote: > In the original code if the "ctx = devm_kzalloc()" allocation failed > then we should have called of_node_put(ep); before returning. It's > actually a bit easier to do the allocation first before assigning > ep = of_graph_get_endpoint_by_regs(). > > Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/gpu/drm/bridge/ite-it66121.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c > index 6980c9801d0d..7149ed40af83 100644 > --- a/drivers/gpu/drm/bridge/ite-it66121.c > +++ b/drivers/gpu/drm/bridge/ite-it66121.c > @@ -898,14 +898,14 @@ static int it66121_probe(struct i2c_client *client, > return -ENXIO; > } > > - ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, 0); > - if (!ep) > - return -EINVAL; > - > ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); > if (!ctx) > return -ENOMEM; > > + ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, 0); > + if (!ep) > + return -EINVAL; > + > ctx->dev = dev; > ctx->client = client; > > Thanks ! Acked-by: Neil Armstrong <narmstrong@baylibre.com> Applying to drm-misc-fixes
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c index 6980c9801d0d..7149ed40af83 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -898,14 +898,14 @@ static int it66121_probe(struct i2c_client *client, return -ENXIO; } - ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, 0); - if (!ep) - return -EINVAL; - ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); if (!ctx) return -ENOMEM; + ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, 0); + if (!ep) + return -EINVAL; + ctx->dev = dev; ctx->client = client;
In the original code if the "ctx = devm_kzalloc()" allocation failed then we should have called of_node_put(ep); before returning. It's actually a bit easier to do the allocation first before assigning ep = of_graph_get_endpoint_by_regs(). Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/gpu/drm/bridge/ite-it66121.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)