diff mbox series

drm/vc4: fix error code in vc4_check_tex_size()

Message ID YrMKK89/viQiaiAg@kili (mailing list archive)
State New, archived
Headers show
Series drm/vc4: fix error code in vc4_check_tex_size() | expand

Commit Message

Dan Carpenter June 22, 2022, 12:25 p.m. UTC 
The vc4_check_tex_size() function is supposed to return false on error
but this error path accidentally returns -ENODEV (which means true).

Fixes: 30f8c74ca9b7 ("drm/vc4: Warn if some v3d code is run on BCM2711")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/vc4/vc4_validate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maxime Ripard June 22, 2022, 2:42 p.m. UTC | #1 
On Wed, 22 Jun 2022 15:25:15 +0300, Dan Carpenter wrote:
> The vc4_check_tex_size() function is supposed to return false on error
> but this error path accidentally returns -ENODEV (which means true).
> 
> 

Applied to drm/drm-misc (drm-misc-fixes).

Thanks!
Maxime
diff mbox series

Patch

diff --git a/drivers/gpu/drm/vc4/vc4_validate.c b/drivers/gpu/drm/vc4/vc4_validate.c
index 833eb623d545..2feba55bcef7 100644
--- a/drivers/gpu/drm/vc4/vc4_validate.c
+++ b/drivers/gpu/drm/vc4/vc4_validate.c
@@ -170,7 +170,7 @@  vc4_check_tex_size(struct vc4_exec_info *exec, struct drm_gem_cma_object *fbo,
 	uint32_t utile_h = utile_height(cpp);
 
 	if (WARN_ON_ONCE(vc4->is_vc5))
-		return -ENODEV;
+		return false;
 
 	/* The shaded vertex format stores signed 12.4 fixed point
 	 * (-2048,2047) offsets from the viewport center, so we should