mbox series

[PULL] drm-xe-next-fixes

Message ID Zo2sO4t32dxqy6Q7@intel.com (mailing list archive)
State New, archived
Headers show
Series [PULL] drm-xe-next-fixes | expand

Pull-request

https://gitlab.freedesktop.org/drm/xe/kernel.git tags/drm-xe-next-fixes-2024-07-09

Message

Rodrigo Vivi July 9, 2024, 9:31 p.m. UTC 
Hi Dave and Sima,

 Here goes a very early drm-xe-next-fixes with 2 important fixes
 that are going to impact user space.

 1. The first one is the rename of the OA stuff from the bad 'perf'
 name to the xe_observation. Although the rename in the uapi
 header is likely inoffensive because our UMDs always copy the
 header to their code, there's a sysfs filename change that is
 impacting mesa.

 For this one Mesa MR is ready and they are only waiting for this
 pull request to be picked by you so they can merge that to Mesa:
 https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30027

 With both sides in place, there won't be any kernel version
 released with the bad naming and no Mesa released using that
 filename. This is the main reason that I'm sending this PR
 earlier than normal.

 2. The second case, which also impact user space is the
 write-back caching mode for system memory on DGFX. In this case
 we introduce a limitation in the cache selection uapi that is
 transparent to UMDs. I mean, no change on their side is needed.
 Coherence is maintained with some know possible visible and
 acceptable/accepted differences in CPU access speed.

 Thanks,
 Rodrigo.

drm-xe-next-fixes-2024-07-09:
UAPI Changes:
- Rename xe perf layer as xe observation layer (Ashutosh)
- Use write-back caching mode for system memory on DGFX (Thomas)

Driver Changes:
- Drop trace_xe_hw_fence_free (Brost)
The following changes since commit 62a05f4ae9c1fb70bc75d494c9c1c373d2c2e374:

  Merge tag 'drm-msm-next-2024-07-04' of https://gitlab.freedesktop.org/drm/msm into drm-next (2024-07-05 12:45:41 +0200)

are available in the Git repository at:

  https://gitlab.freedesktop.org/drm/xe/kernel.git tags/drm-xe-next-fixes-2024-07-09

for you to fetch changes up to 463108053c19f24fa228863824698d5ca72826b6:

  drm/xe: Drop trace_xe_hw_fence_free (2024-07-09 16:21:26 -0400)

----------------------------------------------------------------
UAPI Changes:
- Rename xe perf layer as xe observation layer (Ashutosh)
- Use write-back caching mode for system memory on DGFX (Thomas)

Driver Changes:
- Drop trace_xe_hw_fence_free (Brost)

----------------------------------------------------------------
Ashutosh Dixit (1):
      drm/xe/uapi: Rename xe perf layer as xe observation layer

Matthew Brost (1):
      drm/xe: Drop trace_xe_hw_fence_free

Thomas Hellström (1):
      drm/xe: Use write-back caching mode for system memory on DGFX

 drivers/gpu/drm/xe/Makefile          |   2 +-
 drivers/gpu/drm/xe/xe_bo.c           |  47 +++++++++------
 drivers/gpu/drm/xe/xe_bo_types.h     |   3 +-
 drivers/gpu/drm/xe/xe_device.c       |   4 +-
 drivers/gpu/drm/xe/xe_device_types.h |   2 +-
 drivers/gpu/drm/xe/xe_gt_types.h     |   2 +-
 drivers/gpu/drm/xe/xe_hw_fence.c     |   1 -
 drivers/gpu/drm/xe/xe_module.c       |   6 +-
 drivers/gpu/drm/xe/xe_oa.c           |  34 +++++------
 drivers/gpu/drm/xe/xe_observation.c  |  93 +++++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_observation.h  |  20 +++++++
 drivers/gpu/drm/xe/xe_perf.c         |  92 -----------------------------
 drivers/gpu/drm/xe/xe_perf.h         |  20 -------
 drivers/gpu/drm/xe/xe_trace.h        |   5 --
 include/uapi/drm/xe_drm.h            | 110 +++++++++++++++++++----------------
 15 files changed, 227 insertions(+), 214 deletions(-)
 create mode 100644 drivers/gpu/drm/xe/xe_observation.c
 create mode 100644 drivers/gpu/drm/xe/xe_observation.h
 delete mode 100644 drivers/gpu/drm/xe/xe_perf.c
 delete mode 100644 drivers/gpu/drm/xe/xe_perf.h

Comments

Lucas De Marchi July 10, 2024, 7:42 p.m. UTC | #1 
On Tue, Jul 09, 2024 at 05:31:39PM GMT, Rodrigo Vivi wrote:
>Hi Dave and Sima,
>
> Here goes a very early drm-xe-next-fixes with 2 important fixes
> that are going to impact user space.
>
> 1. The first one is the rename of the OA stuff from the bad 'perf'
> name to the xe_observation. Although the rename in the uapi
> header is likely inoffensive because our UMDs always copy the
> header to their code, there's a sysfs filename change that is
> impacting mesa.
>
> For this one Mesa MR is ready and they are only waiting for this
> pull request to be picked by you so they can merge that to Mesa:
> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30027
>
> With both sides in place, there won't be any kernel version
> released with the bad naming and no Mesa released using that
> filename. This is the main reason that I'm sending this PR
> earlier than normal.
>
> 2. The second case, which also impact user space is the
> write-back caching mode for system memory on DGFX. In this case
> we introduce a limitation in the cache selection uapi that is
> transparent to UMDs. I mean, no change on their side is needed.
> Coherence is maintained with some know possible visible and
> acceptable/accepted differences in CPU access speed.

but this commit is also going to drm-xe-fixes, so I don't think we
should have it in this pull. I'm looking at some changes to dim to avoid
this kind of problem in future.

Lucas De Marchi

>
> Thanks,
> Rodrigo.
>
>drm-xe-next-fixes-2024-07-09:
>UAPI Changes:
>- Rename xe perf layer as xe observation layer (Ashutosh)
>- Use write-back caching mode for system memory on DGFX (Thomas)
>
>Driver Changes:
>- Drop trace_xe_hw_fence_free (Brost)
>The following changes since commit 62a05f4ae9c1fb70bc75d494c9c1c373d2c2e374:
>
>  Merge tag 'drm-msm-next-2024-07-04' of https://gitlab.freedesktop.org/drm/msm into drm-next (2024-07-05 12:45:41 +0200)
>
>are available in the Git repository at:
>
>  https://gitlab.freedesktop.org/drm/xe/kernel.git tags/drm-xe-next-fixes-2024-07-09
>
>for you to fetch changes up to 463108053c19f24fa228863824698d5ca72826b6:
>
>  drm/xe: Drop trace_xe_hw_fence_free (2024-07-09 16:21:26 -0400)
>
>----------------------------------------------------------------
>UAPI Changes:
>- Rename xe perf layer as xe observation layer (Ashutosh)
>- Use write-back caching mode for system memory on DGFX (Thomas)
>
>Driver Changes:
>- Drop trace_xe_hw_fence_free (Brost)
>
>----------------------------------------------------------------
>Ashutosh Dixit (1):
>      drm/xe/uapi: Rename xe perf layer as xe observation layer
>
>Matthew Brost (1):
>      drm/xe: Drop trace_xe_hw_fence_free
>
>Thomas Hellström (1):
>      drm/xe: Use write-back caching mode for system memory on DGFX
>
> drivers/gpu/drm/xe/Makefile          |   2 +-
> drivers/gpu/drm/xe/xe_bo.c           |  47 +++++++++------
> drivers/gpu/drm/xe/xe_bo_types.h     |   3 +-
> drivers/gpu/drm/xe/xe_device.c       |   4 +-
> drivers/gpu/drm/xe/xe_device_types.h |   2 +-
> drivers/gpu/drm/xe/xe_gt_types.h     |   2 +-
> drivers/gpu/drm/xe/xe_hw_fence.c     |   1 -
> drivers/gpu/drm/xe/xe_module.c       |   6 +-
> drivers/gpu/drm/xe/xe_oa.c           |  34 +++++------
> drivers/gpu/drm/xe/xe_observation.c  |  93 +++++++++++++++++++++++++++++
> drivers/gpu/drm/xe/xe_observation.h  |  20 +++++++
> drivers/gpu/drm/xe/xe_perf.c         |  92 -----------------------------
> drivers/gpu/drm/xe/xe_perf.h         |  20 -------
> drivers/gpu/drm/xe/xe_trace.h        |   5 --
> include/uapi/drm/xe_drm.h            | 110 +++++++++++++++++++----------------
> 15 files changed, 227 insertions(+), 214 deletions(-)
> create mode 100644 drivers/gpu/drm/xe/xe_observation.c
> create mode 100644 drivers/gpu/drm/xe/xe_observation.h
> delete mode 100644 drivers/gpu/drm/xe/xe_perf.c
> delete mode 100644 drivers/gpu/drm/xe/xe_perf.h
Rodrigo Vivi July 10, 2024, 8:45 p.m. UTC | #2 
On Wed, Jul 10, 2024 at 02:42:38PM -0500, Lucas De Marchi wrote:
> On Tue, Jul 09, 2024 at 05:31:39PM GMT, Rodrigo Vivi wrote:
> > Hi Dave and Sima,
> > 
> > Here goes a very early drm-xe-next-fixes with 2 important fixes
> > that are going to impact user space.
> > 
> > 1. The first one is the rename of the OA stuff from the bad 'perf'
> > name to the xe_observation. Although the rename in the uapi
> > header is likely inoffensive because our UMDs always copy the
> > header to their code, there's a sysfs filename change that is
> > impacting mesa.
> > 
> > For this one Mesa MR is ready and they are only waiting for this
> > pull request to be picked by you so they can merge that to Mesa:
> > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30027
> > 
> > With both sides in place, there won't be any kernel version
> > released with the bad naming and no Mesa released using that
> > filename. This is the main reason that I'm sending this PR
> > earlier than normal.
> > 
> > 2. The second case, which also impact user space is the
> > write-back caching mode for system memory on DGFX. In this case
> > we introduce a limitation in the cache selection uapi that is
> > transparent to UMDs. I mean, no change on their side is needed.
> > Coherence is maintained with some know possible visible and
> > acceptable/accepted differences in CPU access speed.
> 
> but this commit is also going to drm-xe-fixes, so I don't think we
> should have it in this pull. I'm looking at some changes to dim to avoid
> this kind of problem in future.

okay, let's avoid the churn then.

Sima, Dave, please ignore this PR. I'm going to drop this patch and resend
this PR with the other two.


> 
> Lucas De Marchi
> 
> > 
> > Thanks,
> > Rodrigo.
> > 
> > drm-xe-next-fixes-2024-07-09:
> > UAPI Changes:
> > - Rename xe perf layer as xe observation layer (Ashutosh)
> > - Use write-back caching mode for system memory on DGFX (Thomas)
> > 
> > Driver Changes:
> > - Drop trace_xe_hw_fence_free (Brost)
> > The following changes since commit 62a05f4ae9c1fb70bc75d494c9c1c373d2c2e374:
> > 
> >  Merge tag 'drm-msm-next-2024-07-04' of https://gitlab.freedesktop.org/drm/msm into drm-next (2024-07-05 12:45:41 +0200)
> > 
> > are available in the Git repository at:
> > 
> >  https://gitlab.freedesktop.org/drm/xe/kernel.git tags/drm-xe-next-fixes-2024-07-09
> > 
> > for you to fetch changes up to 463108053c19f24fa228863824698d5ca72826b6:
> > 
> >  drm/xe: Drop trace_xe_hw_fence_free (2024-07-09 16:21:26 -0400)
> > 
> > ----------------------------------------------------------------
> > UAPI Changes:
> > - Rename xe perf layer as xe observation layer (Ashutosh)
> > - Use write-back caching mode for system memory on DGFX (Thomas)
> > 
> > Driver Changes:
> > - Drop trace_xe_hw_fence_free (Brost)
> > 
> > ----------------------------------------------------------------
> > Ashutosh Dixit (1):
> >      drm/xe/uapi: Rename xe perf layer as xe observation layer
> > 
> > Matthew Brost (1):
> >      drm/xe: Drop trace_xe_hw_fence_free
> > 
> > Thomas Hellström (1):
> >      drm/xe: Use write-back caching mode for system memory on DGFX
> > 
> > drivers/gpu/drm/xe/Makefile          |   2 +-
> > drivers/gpu/drm/xe/xe_bo.c           |  47 +++++++++------
> > drivers/gpu/drm/xe/xe_bo_types.h     |   3 +-
> > drivers/gpu/drm/xe/xe_device.c       |   4 +-
> > drivers/gpu/drm/xe/xe_device_types.h |   2 +-
> > drivers/gpu/drm/xe/xe_gt_types.h     |   2 +-
> > drivers/gpu/drm/xe/xe_hw_fence.c     |   1 -
> > drivers/gpu/drm/xe/xe_module.c       |   6 +-
> > drivers/gpu/drm/xe/xe_oa.c           |  34 +++++------
> > drivers/gpu/drm/xe/xe_observation.c  |  93 +++++++++++++++++++++++++++++
> > drivers/gpu/drm/xe/xe_observation.h  |  20 +++++++
> > drivers/gpu/drm/xe/xe_perf.c         |  92 -----------------------------
> > drivers/gpu/drm/xe/xe_perf.h         |  20 -------
> > drivers/gpu/drm/xe/xe_trace.h        |   5 --
> > include/uapi/drm/xe_drm.h            | 110 +++++++++++++++++++----------------
> > 15 files changed, 227 insertions(+), 214 deletions(-)
> > create mode 100644 drivers/gpu/drm/xe/xe_observation.c
> > create mode 100644 drivers/gpu/drm/xe/xe_observation.h
> > delete mode 100644 drivers/gpu/drm/xe/xe_perf.c
> > delete mode 100644 drivers/gpu/drm/xe/xe_perf.h