From patchwork Fri Feb 25 20:51:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Suchanek X-Patchwork-Id: 12760927 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8234C433F5 for ; Fri, 25 Feb 2022 20:51:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4472010E98A; Fri, 25 Feb 2022 20:51:43 +0000 (UTC) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5ACE510E981 for ; Fri, 25 Feb 2022 20:51:41 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id D7034212B8; Fri, 25 Feb 2022 20:51:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1645822298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o51rh/gy7Dq2VMeP0PYE4XhwEj0K93n8O4R2KIcCeoU=; b=fkmq+OECyiKgrGbLObjt6oc3oIufyAIUqfuvh+448zJBQxlNqwFwl+ETKS9jiSPh8HiQi7 06Grq4nXaainwObvmpTN6/9Uea0R0nOPgtnCjOZoCSlM6u+zgqJH+gVRmJydzBrchaWp50 uCO4Pn5vcfNC9NBWQlCWs1vT+yQZZJw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1645822298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o51rh/gy7Dq2VMeP0PYE4XhwEj0K93n8O4R2KIcCeoU=; b=yJgDB3xVx1b+BHxCC2Oj0ZmpBJENIJzgSBoYTNjG/Q7GUs0qGzStKFsrbDearDLjOwAMWW cK9KuOsk+D22LdBQ== Received: from kitsune.suse.cz (kitsune.suse.cz [10.100.12.127]) by relay2.suse.de (Postfix) with ESMTP id 11A2CA3B88; Fri, 25 Feb 2022 20:51:38 +0000 (UTC) From: Michal Suchanek To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Thomas Zimmermann , Javier Martinez Canillas Subject: [PATCH v4 1/3] sysfb: Make config option dependencies explicit Date: Fri, 25 Feb 2022 21:51:33 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: <1f13e6f2-a87c-83ac-7119-8632c8c8ac8e@redhat.com> References: <1f13e6f2-a87c-83ac-7119-8632c8c8ac8e@redhat.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-efi@vger.kernel.org, Geert Uytterhoeven , Dave Hansen , Bjorn Andersson , David Herrmann , Ard Biesheuvel , "H. Peter Anvin" , Krzysztof Kozlowski , Helge Deller , x86@kernel.org, Ingo Molnar , Michal Suchanek , Arnd Bergmann , Borislav Petkov , Thomas Gleixner , Andy Shevchenko , Cristian Marussi , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Martin Mares , Sudeep Holla , linux-video@atrey.karlin.mff.cuni.cz Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" efifb and vesafb requires sysfb implicitly but this is not stated in Kconfig. Add the dependency. With that all drivers that require sysfb depend on it so it can default to disabled. Signed-off-by: Michal Suchanek Reviewed-by: Javier Martinez Canillas --- v4: new patch --- drivers/firmware/Kconfig | 5 ++--- drivers/video/fbdev/Kconfig | 2 ++ 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index 75cb91055c17..5265eca74ba1 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/Kconfig @@ -218,12 +218,11 @@ config QCOM_SCM_DOWNLOAD_MODE_DEFAULT config SYSFB bool - default y - depends on X86 || EFI config SYSFB_SIMPLEFB bool "Mark VGA/VBE/EFI FB as generic system framebuffer" - depends on SYSFB + depends on X86 || EFI + select SYSFB help Firmwares often provide initial graphics framebuffers so the BIOS, bootloader or kernel can show basic video-output during boot for diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 3cfce8dce8d9..907c305caf27 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -628,6 +628,7 @@ config FB_VESA select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT select FB_BOOT_VESA_SUPPORT + select SYSFB help This is the frame buffer device driver for generic VESA 2.0 compliant graphic cards. The older VESA 1.2 cards are not supported. @@ -641,6 +642,7 @@ config FB_EFI select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT + select SYSFB help This is the EFI frame buffer device driver. If the firmware on your platform is EFI 1.10 or UEFI 2.0, select Y to add support for