| Message ID | alpine.DEB.2.02.1304091428270.24675@M2420 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Apr 9, 2013 at 8:35 AM, Xiong Zhou <jencce.kernel@gmail.com> wrote: > From: Xiong Zhou <jencce.kernel@gmail.com> > > This patch fixes build failure of v3.9-rc5. > When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure. > gma5/600 needs acpi_video just like nouveau. > > Failure message: > drivers/built-in.o: In function `psb_driver_load': > kernel-3.9-rc5/drivers/gpu/drm/gma500/psb_drv.c:340: \ > undefined reference to `acpi_video_register' > make: *** [vmlinux] Error 1 > > Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com> > --- > drivers/gpu/drm/gma500/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig > index 1188f0f..d64fc45 100644 > --- a/drivers/gpu/drm/gma500/Kconfig > +++ b/drivers/gpu/drm/gma500/Kconfig > @@ -6,6 +6,7 @@ config DRM_GMA500 > select FB_CFB_IMAGEBLIT > select DRM_KMS_HELPER > select DRM_TTM > + select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT > help > Say yes for an experimental 2D KMS framebuffer driver for the > Intel GMA500 ('Poulsbo') and other Intel IMG based graphics > -- Hi Thanks for catching this, but if I can be picky, I'd prefer if you wrote it like i915 does. E.g. select ACPI_VIDEO if ACPI select BACKLIGHT_CLASS_DEVICE if ACPI ... And you can skip X86 since we already 'depend' on it. Thanks Patrik
On Tue, 9 Apr 2013, Patrik Jakobsson wrote: > On Tue, Apr 9, 2013 at 8:35 AM, Xiong Zhou <jencce.kernel@gmail.com> wrote: > > From: Xiong Zhou <jencce.kernel@gmail.com> > > > > This patch fixes build failure of v3.9-rc5. > > When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure. > > gma5/600 needs acpi_video just like nouveau. > > > > Failure message: > > drivers/built-in.o: In function `psb_driver_load': > > kernel-3.9-rc5/drivers/gpu/drm/gma500/psb_drv.c:340: \ > > undefined reference to `acpi_video_register' > > make: *** [vmlinux] Error 1 > > > > Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com> > > --- > > drivers/gpu/drm/gma500/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig > > index 1188f0f..d64fc45 100644 > > --- a/drivers/gpu/drm/gma500/Kconfig > > +++ b/drivers/gpu/drm/gma500/Kconfig > > @@ -6,6 +6,7 @@ config DRM_GMA500 > > select FB_CFB_IMAGEBLIT > > select DRM_KMS_HELPER > > select DRM_TTM > > + select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT > > help > > Say yes for an experimental 2D KMS framebuffer driver for the > > Intel GMA500 ('Poulsbo') and other Intel IMG based graphics > > -- > > Hi > > Thanks for catching this, but if I can be picky, I'd prefer if you wrote it > like i915 does. E.g. > > select ACPI_VIDEO if ACPI > select BACKLIGHT_CLASS_DEVICE if ACPI > ... > > And you can skip X86 since we already 'depend' on it. > > Thanks > Patrik > Nice advices, Thanks! Xiong
diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig index 1188f0f..d64fc45 100644 --- a/drivers/gpu/drm/gma500/Kconfig +++ b/drivers/gpu/drm/gma500/Kconfig @@ -6,6 +6,7 @@ config DRM_GMA500 select FB_CFB_IMAGEBLIT select DRM_KMS_HELPER select DRM_TTM + select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT help Say yes for an experimental 2D KMS framebuffer driver for the Intel GMA500 ('Poulsbo') and other Intel IMG based graphics