From patchwork Sun Mar 17 18:01:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frej Drejhammar X-Patchwork-Id: 13594784 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D688BC54E67 for ; Sun, 17 Mar 2024 18:02:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 364E710F118; Sun, 17 Mar 2024 18:02:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OtptxIjL"; dkim-atps=neutral Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E32B10E625; Sun, 17 Mar 2024 18:02:29 +0000 (UTC) Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2d27184197cso48395611fa.1; Sun, 17 Mar 2024 11:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710698547; x=1711303347; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eUbeueA1ROk6a8DiyLDqdiiGKg+OYyEnSiWbLatHNh0=; b=OtptxIjLnd6nh5/bLymH3H6K2zd29pZKcTjNGKKzqrr3GKI/YjGytNrn0uN8zFxU4k rsUi3cb4SLXRKFzI76YOAzIatHY1pOncpanutwHjY49CVa8v+soCKUoNiSjxfM1psRNe 0rEP4qfzIxsp9cWyUfnZRrNt33BFX8G7T66m1yua5oOBJs/MvsofGOunLYPfirRBiqhm yz4q2qvhKDCdsxg2GjOOUICmqFUOFJg3LGW2yLhAg0p47U6vXOWDZdRDEPEwTGl4o4b/ sJ52LPyT2Ce2pk5rtj6QmNngM6bo+TtJI0DiEP8/i94Rrr1O18WMHTkTpFJuUGZ6jufD r5RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710698547; x=1711303347; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eUbeueA1ROk6a8DiyLDqdiiGKg+OYyEnSiWbLatHNh0=; b=XSfBohYHq7OUhfPG283vLuiF552DmVzOrk1H0GC/PB645Ic35cJqZGK5UfyKX+uVsZ BL6jQc0Bu1eTNONzEsAYNACmg97LKqklJ2nhejXyKKvJugacJteHr7tFEag1njejxjzo jRgwkKPuLfHYiSJhFWHihmrXLCnGe0D1vI/C8YS7iyvskAEbwVEAKRUUciby99SZ/6xK RX2SjRVDY1hT7P7x5YB35nzL4bHQNcpXnTPt4AxYgPQTglgvv6K+8TUlkBYikf8noVBT dI6gCqYfunKSDJrugZtCRJI0y6rQfAk9m99sMBWCR8zaqCfU2M6l0eanA94z8B+58hZn BAaA== X-Forwarded-Encrypted: i=1; AJvYcCV+JpcJuNiCGVmxZpoH//U+GtKcAQSMQ1m2oGDhDP5cUG/nQnkuWhOuauoLY4ST5cRUYw6nBtrDwPgC9rcs+bws1r8KPMMA217mrzteiGzK X-Gm-Message-State: AOJu0YypxE0p+LjHNq1KWhq/bfNtB7Kaxw9VP48pRVcYxSm9RlUNm7SF RULncEt30p6HNtF7+bK+U9fCTQYa+Q/RtsjCactc6gu2dHQB1ZVXr5QEhdo+NyY= X-Google-Smtp-Source: AGHT+IHYndevLgkLj2qn2VG5Ekz45J5RTZHx/x5titxqY0o/yJQDg+GTMq5OAZ75QcYiLH1jriFPAw== X-Received: by 2002:a2e:3613:0:b0:2d4:57c5:8862 with SMTP id d19-20020a2e3613000000b002d457c58862mr6915147lja.4.1710698547509; Sun, 17 Mar 2024 11:02:27 -0700 (PDT) Received: from betty.fdsoft.se (213-67-237-183-no99.tbcn.telia.com. [213.67.237.183]) by smtp.gmail.com with ESMTPSA id w6-20020a2e9bc6000000b002d2d384519dsm1173483ljj.102.2024.03.17.11.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Mar 2024 11:02:27 -0700 (PDT) Received: from ester.fdsoft.se ([192.168.1.2]) by betty.fdsoft.se with esmtp (Exim 4.97.1) (envelope-from ) id 1rluq2-000000005e0-2eHg; Sun, 17 Mar 2024 19:02:26 +0100 From: Frej Drejhammar To: dri-devel@lists.freedesktop.org Cc: Frej Drejhammar , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: [PATCH 07/11] drm/msm: Use drm_driver_legacy_fb_format() for fbdev Date: Sun, 17 Mar 2024 19:01:32 +0100 Message-ID: X-Mailer: git-send-email 2.44.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Switch to using drm_driver_legacy_fb_format() instead of drm_mode_legacy_fb_format() to use the same logic as for the DRM_IOCTL_MODE_ADDFB ioctl when selecting a framebuffer format. Signed-off-by: Frej Drejhammar Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean Paul Cc: Marijn Suijten Cc: David Airlie Cc: Daniel Vetter Cc: linux-arm-msm@vger.kernel.org Cc: freedreno@lists.freedesktop.org --- This is an evolved version of the changes proposed in "drm: Don't return unsupported formats in drm_mode_legacy_fb_format" [1] following the suggestions of Thomas Zimmermann. [1] https://lore.kernel.org/all/20240310152803.3315-1-frej.drejhammar@gmail.com/ --- drivers/gpu/drm/msm/msm_fbdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c index 030bedac632d..05bedf210572 100644 --- a/drivers/gpu/drm/msm/msm_fbdev.c +++ b/drivers/gpu/drm/msm/msm_fbdev.c @@ -77,7 +77,9 @@ static int msm_fbdev_create(struct drm_fb_helper *helper, uint32_t format; int ret, pitch; - format = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth); + format = drm_driver_legacy_fb_format(dev, + sizes->surface_bpp, + sizes->surface_depth); DBG("create fbdev: %dx%d@%d (%dx%d)", sizes->surface_width, sizes->surface_height, sizes->surface_bpp,