diff mbox series

回复: [PATCH] drm/komeda: add NV12 format to support writeback layer type

Message ID b393669c80274dfcbcf94c60fea8ae76@siengine.com (mailing list archive)
State New, archived
Headers show
Series 回复: [PATCH] drm/komeda: add NV12 format to support writeback layer type | expand

Commit Message

Liu Lucas/刘保柱 Sept. 8, 2023, 8:11 a.m. UTC 
Hi  all,

	Do you have any suggestions for the patch I submitted? Please also let me know, thank you!

Best Regards,
baozhu.liu
-----邮件原件-----
发件人: baozhu.liu <lucas.liu@siengine.com> 
发送时间: 2023年8月29日 17:30
收件人: liviu.dudau@arm.com; airlied@gmail.com; daniel@ffwll.ch
抄送: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Liu Lucas/刘保柱 <lucas.liu@siengine.com>
主题: [PATCH] drm/komeda: add NV12 format to support writeback layer type

When testing the d71 writeback layer function, the output format is set to NV12, and the following error message is displayed:

[drm:komeda_fb_is_layer_supported] Layer TYPE: 4 doesn't support fb FMT: NV12 little-endian (0x3231564e) with modifier: 0x0..

Check the d71 data manual, writeback layer output formats includes NV12 format.

Signed-off-by: baozhu.liu <lucas.liu@siengine.com>
---
 drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.17.1

Comments

Liviu Dudau Sept. 11, 2023, 2:46 p.m. UTC | #1 
Hi Liu,

Sorry about the delay, I was on holiday until 28th and while cleaning up the backlog I've accidentally marked the email
as read and did not reply.


On Fri, Sep 08, 2023 at 08:11:44AM +0000, Liu Lucas/刘保柱 wrote:
> Hi  all,
> 
> 	Do you have any suggestions for the patch I submitted? Please also let me know, thank you!
> 
> Best Regards,
> baozhu.liu
> -----邮件原件-----
> 发件人: baozhu.liu <lucas.liu@siengine.com> 
> 发送时间: 2023年8月29日 17:30
> 收件人: liviu.dudau@arm.com; airlied@gmail.com; daniel@ffwll.ch
> 抄送: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Liu Lucas/刘保柱 <lucas.liu@siengine.com>
> 主题: [PATCH] drm/komeda: add NV12 format to support writeback layer type
> 
> When testing the d71 writeback layer function, the output format is set to NV12, and the following error message is displayed:
> 
> [drm:komeda_fb_is_layer_supported] Layer TYPE: 4 doesn't support fb FMT: NV12 little-endian (0x3231564e) with modifier: 0x0..
> 
> Check the d71 data manual, writeback layer output formats includes NV12 format.
> 
> Signed-off-by: baozhu.liu <lucas.liu@siengine.com>

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

I will push the patch this week into drm-misc-next.

Best regards,
Liviu

> ---
>  drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> index 6c56f5662bc7..80973975bfdb 100644
> --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> @@ -521,7 +521,7 @@ static struct komeda_format_caps d71_format_caps_table[] = {
>  	{__HW_ID(5, 1),	DRM_FORMAT_YUYV,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
>  	{__HW_ID(5, 2),	DRM_FORMAT_YUYV,	RICH,		Flip_H_V,		0, 0},
>  	{__HW_ID(5, 3),	DRM_FORMAT_UYVY,	RICH,		Flip_H_V,		0, 0},
> -	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH,		Flip_H_V,		0, 0},
> +	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH_WB,	Flip_H_V,		0, 0},
>  	{__HW_ID(5, 6),	DRM_FORMAT_YUV420_8BIT,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
>  	{__HW_ID(5, 7),	DRM_FORMAT_YUV420,	RICH,		Flip_H_V,		0, 0},
>  	/* YUV 10bit*/
> --
> 2.17.1
>
Liu Lucas/刘保柱 Sept. 12, 2023, 12:52 p.m. UTC | #2 
Hi Liviu,

	Thank you so much for reviewing this patch!  I expect this patch to be merged.

Best Regards,
baozhu.liu

-----邮件原件-----
发件人: liviu.dudau@arm.com <liviu.dudau@arm.com> 
发送时间: 2023年9月11日 22:46
收件人: Liu Lucas/刘保柱 <lucas.liu@siengine.com>
抄送: airlied@gmail.com; daniel@ffwll.ch; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
主题: Re: 回复: [PATCH] drm/komeda: add NV12 format to support writeback layer type

Hi Liu,

Sorry about the delay, I was on holiday until 28th and while cleaning up the backlog I've accidentally marked the email as read and did not reply.


On Fri, Sep 08, 2023 at 08:11:44AM +0000, Liu Lucas/刘保柱 wrote:
> Hi  all,
> 
> 	Do you have any suggestions for the patch I submitted? Please also let me know, thank you!
> 
> Best Regards,
> baozhu.liu
> -----邮件原件-----
> 发件人: baozhu.liu <lucas.liu@siengine.com>
> 发送时间: 2023年8月29日 17:30
> 收件人: liviu.dudau@arm.com; airlied@gmail.com; daniel@ffwll.ch
> 抄送: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Liu 
> Lucas/刘保柱 <lucas.liu@siengine.com>
> 主题: [PATCH] drm/komeda: add NV12 format to support writeback layer 
> type
> 
> When testing the d71 writeback layer function, the output format is set to NV12, and the following error message is displayed:
> 
> [drm:komeda_fb_is_layer_supported] Layer TYPE: 4 doesn't support fb FMT: NV12 little-endian (0x3231564e) with modifier: 0x0..
> 
> Check the d71 data manual, writeback layer output formats includes NV12 format.
> 
> Signed-off-by: baozhu.liu <lucas.liu@siengine.com>

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

I will push the patch this week into drm-misc-next.

Best regards,
Liviu

> ---
>  drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c 
> b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> index 6c56f5662bc7..80973975bfdb 100644
> --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> @@ -521,7 +521,7 @@ static struct komeda_format_caps d71_format_caps_table[] = {
>  	{__HW_ID(5, 1),	DRM_FORMAT_YUYV,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
>  	{__HW_ID(5, 2),	DRM_FORMAT_YUYV,	RICH,		Flip_H_V,		0, 0},
>  	{__HW_ID(5, 3),	DRM_FORMAT_UYVY,	RICH,		Flip_H_V,		0, 0},
> -	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH,		Flip_H_V,		0, 0},
> +	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH_WB,	Flip_H_V,		0, 0},
>  	{__HW_ID(5, 6),	DRM_FORMAT_YUV420_8BIT,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
>  	{__HW_ID(5, 7),	DRM_FORMAT_YUV420,	RICH,		Flip_H_V,		0, 0},
>  	/* YUV 10bit*/
> --
> 2.17.1
> 

--
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
diff mbox series

Patch

diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
index 6c56f5662bc7..80973975bfdb 100644
--- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
@@ -521,7 +521,7 @@  static struct komeda_format_caps d71_format_caps_table[] = {
 	{__HW_ID(5, 1),	DRM_FORMAT_YUYV,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
 	{__HW_ID(5, 2),	DRM_FORMAT_YUYV,	RICH,		Flip_H_V,		0, 0},
 	{__HW_ID(5, 3),	DRM_FORMAT_UYVY,	RICH,		Flip_H_V,		0, 0},
-	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH,		Flip_H_V,		0, 0},
+	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH_WB,	Flip_H_V,		0, 0},
 	{__HW_ID(5, 6),	DRM_FORMAT_YUV420_8BIT,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
 	{__HW_ID(5, 7),	DRM_FORMAT_YUV420,	RICH,		Flip_H_V,		0, 0},
 	/* YUV 10bit*/