From patchwork Mon Feb 2 21:50:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: bugzilla-daemon@freedesktop.org X-Patchwork-Id: 5764441 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 860109F380 for ; Mon, 2 Feb 2015 21:50:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AFA9D209A7 for ; Mon, 2 Feb 2015 21:50:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id C85E0209A6 for ; Mon, 2 Feb 2015 21:50:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F75E6E045; Mon, 2 Feb 2015 13:50:44 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E0156E045 for ; Mon, 2 Feb 2015 13:50:43 -0800 (PST) Received: by culpepper.freedesktop.org (Postfix, from userid 33) id 248C3721B5; Mon, 2 Feb 2015 21:50:43 +0000 (UTC) From: bugzilla-daemon@freedesktop.org To: dri-devel@lists.freedesktop.org Subject: [Bug 88493] No hdmi audio an agd5f 3.20-wip since consolidate audio_get_pin() functions Date: Mon, 02 Feb 2015 21:50:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DRI X-Bugzilla-Component: DRM/Radeon X-Bugzilla-Version: XOrg git X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: adf.lists@gmail.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: medium X-Bugzilla-Assigned-To: dri-devel@lists.freedesktop.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP https://bugs.freedesktop.org/show_bug.cgi?id=88493 --- Comment #10 from Andy Furniss --- (In reply to Alex Deucher from comment #1) > Are you sure that's the right commit? I don't see any functional change. > It just switches a direct function call to a function pointer. I played a bit more - trying to see if there was any real change or maybe some unlucky h/w timing/order issue. There is a functional change, I guess seeded in a preceding commit. Testing with debugging like - for (i = 0; i < rdev->audio.num_pins; i++) { On the bad commit there is no output after doing xrandr --output HDMI-0 --auto on the commit before there is. On the bad I do get the output with a second use of xrandr. diff --git a/drivers/gpu/drm/radeon/dce6_afmt.c b/drivers/gpu/drm/radeon/dce6_afmt.c index 96f298c..266f32a 100644 --- a/drivers/gpu/drm/radeon/dce6_afmt.c +++ b/drivers/gpu/drm/radeon/dce6_afmt.c @@ -75,6 +75,7 @@ struct r600_audio_pin *dce6_audio_get_pin(struct radeon_device *rdev) { int i; + DRM_ERROR("[ADF] in dce6_audio_get_pin\n"); dce6_afmt_get_connected_pins(rdev);