| Message ID | c50f11c7-932c-47dc-b40f-4ada8b9b6679@stanley.mountain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] drm/tests: Fix a test in drm_test_check_valid_clones() | expand |
On Wed, 12 Feb 2025 18:24:09 +0300, Dan Carpenter wrote: > The drm_atomic_get_crtc_state() function returns error pointers and not > NULL. Update the check to check for error pointers as well as NULL. > > Applied to misc/kernel.git (drm-misc-next). Thanks! Maxime
diff --git a/drivers/gpu/drm/tests/drm_atomic_state_test.c b/drivers/gpu/drm/tests/drm_atomic_state_test.c index 0ab5d9ec4a75..5945c3298901 100644 --- a/drivers/gpu/drm/tests/drm_atomic_state_test.c +++ b/drivers/gpu/drm/tests/drm_atomic_state_test.c @@ -283,7 +283,7 @@ static void drm_test_check_valid_clones(struct kunit *test) KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state); crtc_state = drm_atomic_get_crtc_state(state, priv->crtc); - KUNIT_ASSERT_NOT_NULL(test, crtc_state); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc_state); crtc_state->encoder_mask = param->encoder_mask;
The drm_atomic_get_crtc_state() function returns error pointers and not NULL. Update the check to check for error pointers as well as NULL. Fixes: 88849f24e2ab ("drm/tests: Add test for drm_atomic_helper_check_modeset()") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/gpu/drm/tests/drm_atomic_state_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)