From patchwork Thu Mar 30 15:39:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jani Nikula X-Patchwork-Id: 13194418 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78B12C761A6 for ; Thu, 30 Mar 2023 15:40:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C048D10EEEF; Thu, 30 Mar 2023 15:40:39 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3AEB610EEE8; Thu, 30 Mar 2023 15:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680190831; x=1711726831; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uIurp6EJax5lb5cv527b4HQfjuvAUskbrTIcagNT4rc=; b=iw4TJ6Wl38QyQhWLQbQcflzgORE9EAFwD4JRSvfNjz+Qtkq7sqfsoxsV 1BVE4LdqAG/cY3FffNQw7e/1NIqiXbpFhERdwWrHo2mjQQvOxjOOEEfhJ RFMNFtBvTzLBFb/qo7s/HFc47QjRrsj3VqzT55izpVntGuLxagf/4oFUU nSeUmslbBPNP7cOtFzuxQS3x2QUMj9sYdbHlB1E9A9/nq2jIfJpR6Un+w sUI1JY9k1Zb8acEYYHKnBUB2AvX7GsnhLMbKjNVkohvR+hleBVrgKqfvM eaaqnS24iCwGIt737ywnaE1kGEKZjvFZuE3FPSSAg+QgsAMOfnWPcQR4e g==; X-IronPort-AV: E=McAfee;i="6600,9927,10665"; a="329722199" X-IronPort-AV: E=Sophos;i="5.98,305,1673942400"; d="scan'208";a="329722199" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2023 08:40:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10665"; a="687294910" X-IronPort-AV: E=Sophos;i="5.98,305,1673942400"; d="scan'208";a="687294910" Received: from unknown (HELO localhost) ([10.237.66.160]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2023 08:40:29 -0700 From: Jani Nikula To: dri-devel@lists.freedesktop.org Subject: [PATCH 07/12] drm/exynos: fix is_hdmi usage Date: Thu, 30 Mar 2023 18:39:44 +0300 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org, Seung-Woo Kim , Kyungmin Park Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" drm_connector_update_edid_property() must have been called before to ensure is_hdmi has been populated. Cc: Inki Dae Cc: Seung-Woo Kim Cc: Kyungmin Park Signed-off-by: Jani Nikula --- drivers/gpu/drm/exynos/exynos_hdmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index b7c11bdce2c8..d53d511bcc63 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -893,12 +893,13 @@ static int hdmi_get_modes(struct drm_connector *connector) if (!edid) return -ENODEV; + drm_connector_update_edid_property(connector, edid); + hdata->dvi_mode = !connector->display_info.is_hdmi; DRM_DEV_DEBUG_KMS(hdata->dev, "%s : width[%d] x height[%d]\n", (hdata->dvi_mode ? "dvi monitor" : "hdmi monitor"), edid->width_cm, edid->height_cm); - drm_connector_update_edid_property(connector, edid); cec_notifier_set_phys_addr_from_edid(hdata->notifier, edid); ret = drm_add_edid_modes(connector, edid);