| Message ID | d242a446258e34b2db8990561e51f145df748f83.1713100057.git.baruch@tkos.co.il (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | doc: dma-buf: fix grammar typo | expand |
Am 14.04.24 um 15:07 schrieb Baruch Siach: > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > Documentation/driver-api/dma-buf.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst > index 0c153d79ccc4..29abf1eebf9f 100644 > --- a/Documentation/driver-api/dma-buf.rst > +++ b/Documentation/driver-api/dma-buf.rst > @@ -77,7 +77,7 @@ consider though: > the usual size discover pattern size = SEEK_END(0); SEEK_SET(0). Every other > llseek operation will report -EINVAL. > > - If llseek on dma-buf FDs isn't support the kernel will report -ESPIPE for all > + If llseek on dma-buf FDs isn't supported the kernel will report -ESPIPE for all Looks valid of hand, but checkpatch.pl complains about 2 errors (missing commit message for example) and a warning. Please fix and resend. Thanks, Christian. > cases. Userspace can use this to detect support for discovering the dma-buf > size using llseek. >
Hi Christian, On Mon, Apr 15 2024, Christian König wrote: > Am 14.04.24 um 15:07 schrieb Baruch Siach: >> Signed-off-by: Baruch Siach <baruch@tkos.co.il> >> --- >> Documentation/driver-api/dma-buf.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst >> index 0c153d79ccc4..29abf1eebf9f 100644 >> --- a/Documentation/driver-api/dma-buf.rst >> +++ b/Documentation/driver-api/dma-buf.rst >> @@ -77,7 +77,7 @@ consider though: >> the usual size discover pattern size = SEEK_END(0); SEEK_SET(0). Every other >> llseek operation will report -EINVAL. >> - If llseek on dma-buf FDs isn't support the kernel will report -ESPIPE >> for all >> + If llseek on dma-buf FDs isn't supported the kernel will report -ESPIPE for all > > Looks valid of hand, but checkpatch.pl complains about 2 errors (missing > commit message for example) and a warning. > > Please fix and resend. I only get the checkpatch.pl output listed below with one warning. What parameters do you use? WARNING: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 8 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit d242a446258e ("doc: dma-buf: fix grammar typo") has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Thanks, baruch
diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst index 0c153d79ccc4..29abf1eebf9f 100644 --- a/Documentation/driver-api/dma-buf.rst +++ b/Documentation/driver-api/dma-buf.rst @@ -77,7 +77,7 @@ consider though: the usual size discover pattern size = SEEK_END(0); SEEK_SET(0). Every other llseek operation will report -EINVAL. - If llseek on dma-buf FDs isn't support the kernel will report -ESPIPE for all + If llseek on dma-buf FDs isn't supported the kernel will report -ESPIPE for all cases. Userspace can use this to detect support for discovering the dma-buf size using llseek.
Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- Documentation/driver-api/dma-buf.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)