From patchwork Thu Mar 29 07:49:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksandr Andrushchenko X-Patchwork-Id: 10314597 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E8BC46055B for ; Thu, 29 Mar 2018 07:49:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D653B2A24B for ; Thu, 29 Mar 2018 07:49:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CB0D32A270; Thu, 29 Mar 2018 07:49:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 395C42A271 for ; Thu, 29 Mar 2018 07:49:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F0816E6D0; Thu, 29 Mar 2018 07:49:48 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 021EF6E6D0 for ; Thu, 29 Mar 2018 07:49:46 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id l16so9767600wmh.3 for ; Thu, 29 Mar 2018 00:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=8f7bHJdQsotFX27O0xSc2WVHKBnHjOXvefrzJGSU3yU=; b=eABgL+hjeMmxKnZ6PI+AG6aeV5L0YKp8pLNkoWQtYnBlw9gD6jCipT76RHvff636N5 DjOskEPXygige3N8yhH59AUCXj0w/BgzYhf2rgiKAOSGSa/ehKOPrWj/9JAD5/NSAk5b ttsrXww/JNzHxAJRjwxAIcD+mHrtOaVWPRmJgqzy0vxfv6XucspYrOM1StYfpO7lblze 3Tlt0SV3zedmUA5/FZZ1gwHt06DaEtIRySUF8BSrS7nYf5J8e5QvF/YsXiSu6QJoy7U2 0t7fruGvYv4V7OEXepDLTITvu3mORZeAjXgcb9N4IGU9lFnFH7jFnKYHSDjIbAhq/yzT G8rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=8f7bHJdQsotFX27O0xSc2WVHKBnHjOXvefrzJGSU3yU=; b=kP4vU5+YwV0D8ZhtMg31xuluT5PlhtqQdhvCfT7BiV+I8WY2luC/Nppqg3RGRa05et rxjiYpIrFBWbh9CEpAjohTY5YjcZCC75ggCnMZ0YKTuYShzG5MOPetXnle2mM6G+RBGn sCdTjcPo/RgX4FX9IW7YItcQMhS88ybP+Gn3DWHlEOPVtGugKIZTMXHFXpkmKXIYlzt9 9xbCiNkAcXLVMZ2+B1LTg9lyNK3bTomXVZP6t108ZbxTMlyF+A7LjTxcJM/MP2yY8ttV 93z0s6aq241mXfZuRIFJbvQ9rgRMeQYfqET5L31rPQqoJw4S3C3honP1lPVFSoFbAmmW sPvg== X-Gm-Message-State: AElRT7HZ7yyDJbZ2iDcYAkn0t8F4J+2LNN9wEjNjcgQa0Jw72ThNryNQ S3IQT05uZXMp65hNkw63wnE= X-Google-Smtp-Source: AIpwx49UJWIKDqAPkc8Lz0+Ohd2Z1ftUQzpT5W53ZxViEouhvZLw914ZVkJDdH6NHWgz8gje28eNgw== X-Received: by 10.28.239.18 with SMTP id n18mr5275002wmh.56.1522309785266; Thu, 29 Mar 2018 00:49:45 -0700 (PDT) Received: from [10.17.182.9] (ll-59.209.223.85.sovam.net.ua. [85.223.209.59]) by smtp.gmail.com with ESMTPSA id 142sm1383830wmq.47.2018.03.29.00.49.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Mar 2018 00:49:43 -0700 (PDT) Subject: Re: [PATCH v4 2/2] drm/xen-front: Add support for Xen PV display frontend To: daniel.vetter@intel.com, jgross@suse.com, konrad.wilk@oracle.com, airlied@linux.ie, Oleksandr Andrushchenko , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com References: <1522219661-26827-1-git-send-email-andr2000@gmail.com> <1522219661-26827-3-git-send-email-andr2000@gmail.com> <20180328074251.GE14155@phenom.ffwll.local> <32481355-27f6-695b-c6c1-8113ea268a33@gmail.com> <20180329071748.GG3881@phenom.ffwll.local> From: Oleksandr Andrushchenko Message-ID: Date: Thu, 29 Mar 2018 10:49:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180329071748.GG3881@phenom.ffwll.local> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 03/29/2018 10:17 AM, Daniel Vetter wrote: > On Wed, Mar 28, 2018 at 01:29:46PM +0300, Oleksandr Andrushchenko wrote: >> Hi, Daniel! >> >> I just noticed I have missed one change in the patch: >> the below must be static. >> >> On 03/28/2018 10:42 AM, Daniel Vetter wrote: >>> +enum drm_mode_status display_mode_valid(struct drm_crtc *crtc, >>> + const struct drm_display_mode *mode) >>> +{ >>> + struct xen_drm_front_drm_pipeline *pipeline = >>> + container_of(crtc, >> Could you please amend the patch in attachment >> when merging, so I don't resend? > Merging is up to you, as soon as you have your commit rights. Thank you, meanwhile I'll need to rebase onto the latest drm-tip fixing 2 more minor issues (attached) and making the driver work after the API change [1]. So, I'll post v4 right after fd.o is back online with the v3..v4 diff to make review simpler > -Daniel Thank you, Oleksandr >> Thank you in advance, >> Oleksandr >> From 3a82d76bd3d954056b760e5d1d09e2f96a2786ef Mon Sep 17 00:00:00 2001 >> From: Oleksandr Andrushchenko >> Date: Wed, 28 Mar 2018 13:24:04 +0300 >> Subject: [PATCH] drm/xen-front: Make display_mode_valid static >> >> Signed-off-by: Oleksandr Andrushchenko >> --- >> drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c >> index 545049dfaf0a..bd676be5a0db 100644 >> --- a/drivers/gpu/drm/xen/xen_drm_front_kms.c >> +++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c >> @@ -273,7 +273,7 @@ static void display_update(struct drm_simple_display_pipe *pipe, >> drm_dev_exit(idx); >> } >> >> -enum drm_mode_status display_mode_valid(struct drm_crtc *crtc, >> +static enum drm_mode_status display_mode_valid(struct drm_crtc *crtc, >> const struct drm_display_mode *mode) >> { >> struct xen_drm_front_drm_pipeline *pipeline = >> -- >> 2.7.4 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > [1] https://github.com/freedesktop/drm-misc/commit/0c9c7fd00e17907efb35697ecb9f2df39a0b536c From a6668b48003b46cd711f7e56faaf35dbad769c03 Mon Sep 17 00:00:00 2001 From: Oleksandr Andrushchenko Date: Thu, 29 Mar 2018 09:13:11 +0300 Subject: [PATCH 2/2] drm/xen-front: Align documentation title w/ other drivers Align title of the documentation for the driver with the rest of the drivers, e.g. have drm/xen-front in front of the title. Signed-off-by: Oleksandr Andrushchenko --- Documentation/gpu/xen-front.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/gpu/xen-front.rst b/Documentation/gpu/xen-front.rst index 8188e03c9d23..009d942386c5 100644 --- a/Documentation/gpu/xen-front.rst +++ b/Documentation/gpu/xen-front.rst @@ -1,6 +1,6 @@ -==================================== -Xen para-virtualized frontend driver -==================================== +==================================================== + drm/xen-front Xen para-virtualized frontend driver +==================================================== This frontend driver implements Xen para-virtualized display according to the display protocol described at -- 2.7.4