video: hyperv_fb: Reduce scope for the variable “page” in hvfb_get_phymem()

Commit Message

Markus Elfring Dec. 10, 2020, 4:17 p.m. UTC

From: Markus Elfring <[e-mail]>
Date: Thu, 10 Dec 2020 17:00:13 +0100

A local variable was used only within an if branch.
Thus move the definition for the variable “page” into the corresponding
code block.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[e-mail]>
---
 drivers/video/fbdev/hyperv_fb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--
2.29.2

Patch

diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
index c8b0ae676809..e18fa8793608 100644
--- a/drivers/video/fbdev/hyperv_fb.c
+++ b/drivers/video/fbdev/hyperv_fb.c
@@ -961,7 +961,6 @@  static void hvfb_get_option(struct fb_info *info)
 static phys_addr_t hvfb_get_phymem(struct hv_device *hdev,
 				   unsigned int request_size)
 {
-	struct page *page = NULL;
 	dma_addr_t dma_handle;
 	void *vmem;
 	phys_addr_t paddr = 0;
@@ -972,7 +971,7 @@  static phys_addr_t hvfb_get_phymem(struct hv_device *hdev,

 	if (order < MAX_ORDER) {
 		/* Call alloc_pages if the size is less than 2^MAX_ORDER */
-		page = alloc_pages(GFP_KERNEL | __GFP_ZERO, order);
+		struct page *page = alloc_pages(GFP_KERNEL | __GFP_ZERO, order);
 		if (!page)
 			return -1;