| Message ID | ddb10df1316ef585930cda7718643a580f4fe37b.1575390741.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | video, drm, etc: constify fbops in struct fb_info | expand |
On Tue, 03 Dec 2019, Jani Nikula <jani.nikula@intel.com> wrote: > Now that the fbops member of struct fb_info is const, we can start > making the ops const as well. > > v2: fix typo (Christophe de Dinechin) > > Cc: Kirti Wankhede <kwankhede@nvidia.com> > Cc: kvm@vger.kernel.org > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Kirti, may I have your ack to merge this through drm-misc please? BR, Jani. > --- > samples/vfio-mdev/mdpy-fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c > index 2719bb259653..21dbf63d6e41 100644 > --- a/samples/vfio-mdev/mdpy-fb.c > +++ b/samples/vfio-mdev/mdpy-fb.c > @@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info) > iounmap(info->screen_base); > } > > -static struct fb_ops mdpy_fb_ops = { > +static const struct fb_ops mdpy_fb_ops = { > .owner = THIS_MODULE, > .fb_destroy = mdpy_fb_destroy, > .fb_setcolreg = mdpy_fb_setcolreg,
On 12/9/2019 7:31 PM, Jani Nikula wrote: > On Tue, 03 Dec 2019, Jani Nikula <jani.nikula@intel.com> wrote: >> Now that the fbops member of struct fb_info is const, we can start >> making the ops const as well. >> >> v2: fix typo (Christophe de Dinechin) >> >> Cc: Kirti Wankhede <kwankhede@nvidia.com> >> Cc: kvm@vger.kernel.org >> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > Kirti, may I have your ack to merge this through drm-misc please? > > BR, > Jani. > >> --- >> samples/vfio-mdev/mdpy-fb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c >> index 2719bb259653..21dbf63d6e41 100644 >> --- a/samples/vfio-mdev/mdpy-fb.c >> +++ b/samples/vfio-mdev/mdpy-fb.c >> @@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info) >> iounmap(info->screen_base); >> } >> >> -static struct fb_ops mdpy_fb_ops = { >> +static const struct fb_ops mdpy_fb_ops = { >> .owner = THIS_MODULE, >> .fb_destroy = mdpy_fb_destroy, >> .fb_setcolreg = mdpy_fb_setcolreg, > Acked-by : Kirti Wankhede <kwankhede@nvidia.com>
On Tue, 10 Dec 2019, Kirti Wankhede <kwankhede@nvidia.com> wrote: > On 12/9/2019 7:31 PM, Jani Nikula wrote: >> On Tue, 03 Dec 2019, Jani Nikula <jani.nikula@intel.com> wrote: >>> Now that the fbops member of struct fb_info is const, we can start >>> making the ops const as well. >>> >>> v2: fix typo (Christophe de Dinechin) >>> >>> Cc: Kirti Wankhede <kwankhede@nvidia.com> >>> Cc: kvm@vger.kernel.org >>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> >>> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> >> Kirti, may I have your ack to merge this through drm-misc please? >> >> BR, >> Jani. >> >>> --- >>> samples/vfio-mdev/mdpy-fb.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c >>> index 2719bb259653..21dbf63d6e41 100644 >>> --- a/samples/vfio-mdev/mdpy-fb.c >>> +++ b/samples/vfio-mdev/mdpy-fb.c >>> @@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info) >>> iounmap(info->screen_base); >>> } >>> >>> -static struct fb_ops mdpy_fb_ops = { >>> +static const struct fb_ops mdpy_fb_ops = { >>> .owner = THIS_MODULE, >>> .fb_destroy = mdpy_fb_destroy, >>> .fb_setcolreg = mdpy_fb_setcolreg, >> > > Acked-by : Kirti Wankhede <kwankhede@nvidia.com> Thanks, pushed to drm-misc-next. BR, Jani.
diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c index 2719bb259653..21dbf63d6e41 100644 --- a/samples/vfio-mdev/mdpy-fb.c +++ b/samples/vfio-mdev/mdpy-fb.c @@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info) iounmap(info->screen_base); } -static struct fb_ops mdpy_fb_ops = { +static const struct fb_ops mdpy_fb_ops = { .owner = THIS_MODULE, .fb_destroy = mdpy_fb_destroy, .fb_setcolreg = mdpy_fb_setcolreg,