| Message ID | de0273a8-8910-4ac4-b4ed-f7691c4d2ca6@kili.mountain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panel: magnachip: Prevent error pointer dereference in probe | expand |
On Wed, Mar 22, 2023 at 12:07:10PM +0300, Dan Carpenter wrote: > Don't dereference "db->dsi_dev" when it is an error pointer. > > Fixes: 249a4f5e663c ("drm/panel: Add Magnachip D53E6EA8966 Panel Driver") > Signed-off-by: Dan Carpenter <error27@gmail.com> > --- > drivers/gpu/drm/panel/panel-magnachip-d53e6ea8966.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-magnachip-d53e6ea8966.c b/drivers/gpu/drm/panel/panel-magnachip-d53e6ea8966.c > index 8c362c40227f..26d358b9b85a 100644 > --- a/drivers/gpu/drm/panel/panel-magnachip-d53e6ea8966.c > +++ b/drivers/gpu/drm/panel/panel-magnachip-d53e6ea8966.c > @@ -418,7 +418,7 @@ static int d53e6ea8966_probe(struct spi_device *spi) > if (IS_ERR(db->dsi_dev)) { > dev_err(dev, "failed to register dsi device: %ld\n", > PTR_ERR(db->dsi_dev)); > - ret = PTR_ERR(db->dsi_dev); > + return PTR_ERR(db->dsi_dev); > } > > db->dsi_dev->lanes = 2; > -- > 2.39.1 > Thank you for the patch, this looks good to me. Not sure how I missed that. Chris Morgan
On Wed, Mar 22, 2023 at 10:07 AM Dan Carpenter <error27@gmail.com> wrote: > Don't dereference "db->dsi_dev" when it is an error pointer. > > Fixes: 249a4f5e663c ("drm/panel: Add Magnachip D53E6EA8966 Panel Driver") > Signed-off-by: Dan Carpenter <error27@gmail.com> Patch applied to drm-misc-next! Yours, Linus Walleij
diff --git a/drivers/gpu/drm/panel/panel-magnachip-d53e6ea8966.c b/drivers/gpu/drm/panel/panel-magnachip-d53e6ea8966.c index 8c362c40227f..26d358b9b85a 100644 --- a/drivers/gpu/drm/panel/panel-magnachip-d53e6ea8966.c +++ b/drivers/gpu/drm/panel/panel-magnachip-d53e6ea8966.c @@ -418,7 +418,7 @@ static int d53e6ea8966_probe(struct spi_device *spi) if (IS_ERR(db->dsi_dev)) { dev_err(dev, "failed to register dsi device: %ld\n", PTR_ERR(db->dsi_dev)); - ret = PTR_ERR(db->dsi_dev); + return PTR_ERR(db->dsi_dev); } db->dsi_dev->lanes = 2;
Don't dereference "db->dsi_dev" when it is an error pointer. Fixes: 249a4f5e663c ("drm/panel: Add Magnachip D53E6EA8966 Panel Driver") Signed-off-by: Dan Carpenter <error27@gmail.com> --- drivers/gpu/drm/panel/panel-magnachip-d53e6ea8966.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)