| Message ID | f1cb7c18-5580-65f4-9eac-ffc0402963b4@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] AMDGPU: Specify get_argument function for ci_smu_funcs | expand |
Applied. Thanks! Alex On Thu, Aug 27, 2020 at 7:37 AM Sandeep Raghuraman <sandy.8925@gmail.com> wrote: > > Starting in Linux 5.8, the graphics and memory clock frequency were not being reported for CIK cards. This is a regression, since they were reported correctly in Linux 5.7. This was due to changes in commit a0ec225633d9f681e393a1827f29f02c837deb84. > > After investigation, I discovered that the smum_send_msg_to_smc() function, attempts to call the corresponding get_argument() function of ci_smu_funcs. However, the get_argument() function is not defined in ci_smu_funcs. > > This patch fixes the bug by specifying the correct get_argument() function. > > Signed-off-by: Sandeep Raghuraman <sandy.8925@gmail.com> > > --- > drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c > index ad54f4500af1..63016c14b942 100644 > --- a/drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c > @@ -37,6 +37,7 @@ > #include "cgs_common.h" > #include "atombios.h" > #include "pppcielanes.h" > +#include "smu7_smumgr.h" > > #include "smu/smu_7_0_1_d.h" > #include "smu/smu_7_0_1_sh_mask.h" > @@ -2948,6 +2949,7 @@ const struct pp_smumgr_func ci_smu_funcs = { > .request_smu_load_specific_fw = NULL, > .send_msg_to_smc = ci_send_msg_to_smc, > .send_msg_to_smc_with_parameter = ci_send_msg_to_smc_with_parameter, > + .get_argument = smu7_get_argument, > .download_pptable_settings = NULL, > .upload_pptable_settings = NULL, > .get_offsetof = ci_get_offsetof, > -- > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c index ad54f4500af1..63016c14b942 100644 --- a/drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c +++ b/drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c @@ -37,6 +37,7 @@ #include "cgs_common.h" #include "atombios.h" #include "pppcielanes.h" +#include "smu7_smumgr.h" #include "smu/smu_7_0_1_d.h" #include "smu/smu_7_0_1_sh_mask.h" @@ -2948,6 +2949,7 @@ const struct pp_smumgr_func ci_smu_funcs = { .request_smu_load_specific_fw = NULL, .send_msg_to_smc = ci_send_msg_to_smc, .send_msg_to_smc_with_parameter = ci_send_msg_to_smc_with_parameter, + .get_argument = smu7_get_argument, .download_pptable_settings = NULL, .upload_pptable_settings = NULL, .get_offsetof = ci_get_offsetof,
Starting in Linux 5.8, the graphics and memory clock frequency were not being reported for CIK cards. This is a regression, since they were reported correctly in Linux 5.7. This was due to changes in commit a0ec225633d9f681e393a1827f29f02c837deb84. After investigation, I discovered that the smum_send_msg_to_smc() function, attempts to call the corresponding get_argument() function of ci_smu_funcs. However, the get_argument() function is not defined in ci_smu_funcs. This patch fixes the bug by specifying the correct get_argument() function. Signed-off-by: Sandeep Raghuraman <sandy.8925@gmail.com> --- drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c | 2 ++ 1 file changed, 2 insertions(+) --