From patchwork Wed Sep 21 04:47:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: poma X-Patchwork-Id: 9342817 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 33802607D4 for ; Wed, 21 Sep 2016 04:47:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1CBEB29DA5 for ; Wed, 21 Sep 2016 04:47:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0EF1F29E9A; Wed, 21 Sep 2016 04:47:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A139029DA5 for ; Wed, 21 Sep 2016 04:47:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0AC3F6E786; Wed, 21 Sep 2016 04:47:42 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C0D66E786 for ; Wed, 21 Sep 2016 04:47:39 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id l132so6463980wmf.1 for ; Tue, 20 Sep 2016 21:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=cgFuVD19acMTOGOlo7+IoDh3rFT6ISO61HFCkHnehO4=; b=hPf1gEUDjTN9dB5QSFkCpJaM7XATjIh0tJInDvCDBidGABD+BdklxrdxuojGF3V2nJ tUfrrxSfsLUAbA8nk3kqn3wkMfY54/yyNCZREfSdPCSLuu2WU9YmLFU+AoGA5PFJdTBy ILaseLYj79B2TwTu2LbG8Y//eY0WtNViqcwXbC64fgI9M8VW1WArJKWdoBC+URXz9H4r OStxwubjVDzLP84kGFRhUifqy1w6YZLF+xKWiM8OCOQD1/2ye59TEFcdB5x6560Nrpl5 XZ3rAcCgr3uxt2/mDShML3t0NSvGdaelAm+ItllmvhR0/UKfFLSMhxJYe9efoXhPvs7o Hf2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=cgFuVD19acMTOGOlo7+IoDh3rFT6ISO61HFCkHnehO4=; b=Gg5aoVkJbg0Vg79MAI3PR74dFRCr9jtU97v3JgH/I+y5lR1OvWbhxgt7Gn8UI8qvEt A4flv+JWSDD1ezgNQGQCjdTlIaWAswBB+GIM0J827LJdbsDH16x1PdLpvzs1FtBCv+qf M5qabQiSkcyaA4ULO731M+KqFYiV9DAA3fGhv/8qcz8WpkglItpUesOhTLodBr/7/SCc 6oAgv7Ac42RlnfSuPKE+m1oeHLcRtWi7f/hg+NuWcLb1z61ucLfxpXLmAOI9kqeVrX46 7QfnWvAah9aiGuq/a7pjKq+bMCp2cWV1TE+BRC+hzlRnLkRb2KAkQePZ/dI3SMKxRE1D V46g== X-Gm-Message-State: AE9vXwOFKaebRLoDJC6ZMlshbYV8NWu10qjZUzO1HvWZDySruZUlKmYvcMnylEa2T+yPjQ== X-Received: by 10.194.93.8 with SMTP id cq8mr30023188wjb.10.1474433256857; Tue, 20 Sep 2016 21:47:36 -0700 (PDT) Received: from localhost (iskon7615.duo.carnet.hr. [31.147.125.191]) by smtp.gmail.com with ESMTPSA id au10sm31496380wjc.12.2016.09.20.21.47.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Sep 2016 21:47:36 -0700 (PDT) Subject: Re: [PATCH] drm/udl: Fix for the X server screen update v3 To: Daniel Vetter References: <750b2697-456e-bb82-b287-f594450f092e@tronnes.org> <4e8e06da-717f-a4ca-0e87-ce3f5113e9b2@gmail.com> <34ff0a5d-b1ea-b5f9-f49e-4a2d24e8be7f@gmail.com> <88ba6722-c757-7685-5e89-6abe177aef44@gmail.com> From: poma Message-ID: Date: Wed, 21 Sep 2016 06:47:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Cc: Dave Airlie , Gerd Hoffmann , DRI Development X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Within X server, on top of DisplayLink GPU USB2.0 device, screen content is not refreshed i.e. updated. This fixes commit: - e375882406d0cc24030746638592004755ed4ae0 "drm/udl: Use drm_fb_helper deferred_io support" Thanks Noralf and Daniel for the comments. Tested-by: poma Reviewed-by: David Herrmann --- drivers/gpu/drm/udl/udl_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c index d5df555..cc2daba 100644 --- a/drivers/gpu/drm/udl/udl_fb.c +++ b/drivers/gpu/drm/udl/udl_fb.c @@ -122,7 +122,7 @@ int udl_handle_damage(struct udl_framebuffer *fb, int x, int y, return 0; cmd = urb->transfer_buffer; - for (i = y; i < height ; i++) { + for (i = y; i < y + height ; i++) { const int line_offset = fb->base.pitches[0] * i; const int byte_offset = line_offset + (x * bpp); const int dev_byte_offset = (fb->base.width * bpp * i) + (x * bpp);