From patchwork Fri Apr 29 17:09:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Iwai X-Patchwork-Id: 741631 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p3THA7e8030049 for ; Fri, 29 Apr 2011 17:10:28 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 309BB9E9C3 for ; Fri, 29 Apr 2011 10:10:06 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTP id 68F539E709 for ; Fri, 29 Apr 2011 10:09:54 -0700 (PDT) Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2]) by mx2.suse.de (Postfix) with ESMTP id 6253E8738D; Fri, 29 Apr 2011 19:09:52 +0200 (CEST) Date: Fri, 29 Apr 2011 19:09:52 +0200 Message-ID: From: Takashi Iwai To: Melchior FRANZ Subject: Re: Linux 2.6.39-rc5 In-Reply-To: <201104291758.06975@rk-nord.at> References: <201104291758.06975@rk-nord.at> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: Linus Torvalds , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 29 Apr 2011 17:10:29 +0000 (UTC) At Fri, 29 Apr 2011 17:58:06 +0200, Melchior FRANZ wrote: > > * Linus Torvalds -- Wednesday 27 April 2011: > > Go forth and test, > > Doesn't work on my notebook with i915/KMS. But then again, neither did > 2.6.38 or any of its stable releases. The last working version was > 2.6.38-rc8. The problem has been reported[1], but the bug got closed > in the wrong assumption that the bug is fixed. I reported that, too. > No reactions to that. > > The bug was introduced with commit ba3820ade317ee36e496b9b40d2ec3987dd4aef0 > by Takashi Iwai. The result is that when using KMS my notebook's[2] screen > remains dark, because the backlight isn't turned on. > > Reverting commit ba3820ade317ee36e496b9b40d2ec3987dd4aef0 makes my > notebook work correctly again as it used to in 2.6.38-rc8 and before. Could you check whether the patch below changes the behavior? If this cures, it means that the backlight-combo mode doesn't work on your machine. Takashi diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index a06ff07..bf61e02 100644 --- a/drivers/gpu/drm/i915/intel_panel.c +++ b/drivers/gpu/drm/i915/intel_panel.c @@ -116,11 +116,13 @@ static int is_backlight_combination_mode(struct drm_device *dev) { struct drm_i915_private *dev_priv = dev->dev_private; +#if 0 if (INTEL_INFO(dev)->gen >= 4) return I915_READ(BLC_PWM_CTL2) & BLM_COMBINATION_MODE; if (IS_GEN2(dev)) return I915_READ(BLC_PWM_CTL) & BLM_LEGACY_MODE; +#endif return 0; }