diff mbox series

[v2,2/2] unit: update test-ecc with compressed point bug fix

Message ID 20231010142506.261152-2-prestwoj@gmail.com (mailing list archive)
State New
Headers show
Series [v2,1/2] ecc: fix incorrect derivation of compressed points | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success

Commit Message

James Prestwood Oct. 10, 2023, 2:25 p.m. UTC 
---
 unit/test-ecc.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

Denis Kenzior Oct. 11, 2023, 3:26 p.m. UTC | #1 
Hi James,

On 10/10/23 09:25, James Prestwood wrote:
> ---
>   unit/test-ecc.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)


Not related to this, but unit tests for ell no longer pass:
PASS: unit/test-pem
./build-aux/test-driver: line 112: 218850 Aborted                 (core dumped) 
"$@" >> "$log_file" 2>&1
FAIL: unit/test-tls
./build-aux/test-driver: line 112: 218865 Aborted                 (core dumped) 
"$@" >> "$log_file" 2>&1
FAIL: unit/test-key
============================================================================
Testsuite summary for ell 0.59
============================================================================
# TOTAL: 44
# PASS:  42
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0

[denkenz@archdev ell]$ uname -a
Linux archdev 6.5.3-arch1-1 #1 SMP PREEMPT_DYNAMIC Wed, 13 Sep 2023 08:37:40 
+0000 x86_64 GNU/Linux

Regards,
-Denis
diff mbox series

Patch

diff --git a/unit/test-ecc.c b/unit/test-ecc.c
index 21f73f1..05a89ab 100644
--- a/unit/test-ecc.c
+++ b/unit/test-ecc.c
@@ -374,28 +374,28 @@  struct compressed_point_data {
 
 static struct compressed_point_data compressed_tests[] = {
 	{
-		/* BIT1, subtraction performed */
+		/* BIT0, computed Y is odd, subtraction performed */
 		.x = "19b3fec1c000a888ee9c44272e4d7317e6e36577fc9d53e1edfb4e296b0b7ce1",
 		.exp_y = "a8f9efd0ab526cd930870779621f4e9a53d4e78887ac9f4ed45ff75ded32b158",
-		.type = L_ECC_POINT_TYPE_COMPRESSED_BIT1,
+		.type = L_ECC_POINT_TYPE_COMPRESSED_BIT0,
 	},
 	{
-		/* BIT1, no subtraction */
+		/* BIT0, computed Y is even, no subtraction */
 		.x = "958df5997362a9695ad73938c86be34a4730da877eccaaf8b189e73ff20e67c3",
 		.exp_y = "1042f37262ded34d8424c1728a1ed23a726645b71db30a38f2932001a2027f46",
-		.type = L_ECC_POINT_TYPE_COMPRESSED_BIT1,
+		.type = L_ECC_POINT_TYPE_COMPRESSED_BIT0,
 	},
 	{
-		/* BIT0, subtraction performed */
+		/* BIT1, computed Y is even, subtraction performed */
 		.x = "069bd56634454ca76e7ba434244137509141cbbf532586c6b36e9b5be8a2cc34",
 		.exp_y = "f4f34d46e4bdc1473fec4b4c8724f349375a8a602f5e83c260d6724e64ec7e99",
-		.type = L_ECC_POINT_TYPE_COMPRESSED_BIT0,
+		.type = L_ECC_POINT_TYPE_COMPRESSED_BIT1,
 	},
 	{
-		/* BIT0, no subtraction */
+		/* BIT1, computed Y is odd, no subtraction */
 		.x = "8cade296a68e0c40bcf45a049f1993263bdc8524825e2be44b14ce114e475df0",
 		.exp_y = "94ed7d09b2a0e95d8df993eaf81eb64d5ff734d01da57e53b2e0277199bc5897",
-		.type = L_ECC_POINT_TYPE_COMPRESSED_BIT0,
+		.type = L_ECC_POINT_TYPE_COMPRESSED_BIT1,
 	},
 };