diff mbox series

unit: don't specify tcp hostname in dbus config

Message ID 20240617122939.1249697-1-martin@geanix.com (mailing list archive)
State New
Headers show
Series unit: don't specify tcp hostname in dbus config | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
prestwoj/iwd-ci-setupell success Prep - Setup ELL
prestwoj/iwd-ci-makedistcheck success Make Distcheck
prestwoj/iwd-ci-build success Build - Configure
prestwoj/iwd-ci-makecheckvalgrind success Make Check w/Valgrind
prestwoj/iwd-ci-makecheck success Make Check
prestwoj/iwd-ci-clang success clang PASS
prestwoj/iwd-ci-testrunner success test-runner PASS

Commit Message

Martin Hundebøll June 17, 2024, 12:29 p.m. UTC 
Testing dbus with no network interfaces available on the host fails
with:
  dbus-daemon[291]: Failed to start message bus: Failed to lookup host/port: "*:14046": Name or service not known (-2)

Seems like "*" isn't a valid hostname in such cases:
  https://bugs.freedesktop.org/show_bug.cgi?id=28979

According to the linked issue, the fix is to simply omit the host= and
bind= parameters in the config.
---
 unit/dbus.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Denis Kenzior June 20, 2024, 3:01 p.m. UTC | #1 
Hi Martin,

On 6/17/24 7:29 AM, Martin Hundebøll wrote:
> Testing dbus with no network interfaces available on the host fails
> with:
>    dbus-daemon[291]: Failed to start message bus: Failed to lookup host/port: "*:14046": Name or service not known (-2)
> 
> Seems like "*" isn't a valid hostname in such cases:
>    https://bugs.freedesktop.org/show_bug.cgi?id=28979
> 
> According to the linked issue, the fix is to simply omit the host= and
> bind= parameters in the config.
> ---
>   unit/dbus.conf | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks.

Regards,
-Denis
diff mbox series

Patch

diff --git a/unit/dbus.conf b/unit/dbus.conf
index 5fe41a9ad6a6..3651e44538b1 100644
--- a/unit/dbus.conf
+++ b/unit/dbus.conf
@@ -7,7 +7,7 @@ 
   <allow_anonymous />
 
   <listen>unix:path=/tmp/ell-test-bus</listen>
-  <listen>tcp:host=localhost,bind=*,port=14046,family=ipv4</listen>
+  <listen>tcp:port=14046</listen>
   <apparmor mode="disabled" />
 
   <policy context="default">