| Message ID | 20231121223909.4617-1-ebiggers@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | xfstests: test custom crypto data unit size | expand |
On Tue, Nov 21, 2023 at 02:39:05PM -0800, Eric Biggers wrote: > This series adds a test that verifies the on-disk format of encrypted > files that use a crypto data unit size that differs from the filesystem > block size. This tests the functionality that was introduced in Linux > 6.7 by kernel commit 5b1188847180 ("fscrypt: support crypto data unit > size less than filesystem block size"). Hi Zorro, can you consider applying this series? It's been out for review for 3 months, so I don't think reviews are going to come in. The prerequisite xfsprogs patch is already present on the for-next branch of xfsprogs. Thanks! - Eric
On Wed, Jan 10, 2024 at 07:54:44PM -0800, Eric Biggers wrote: > On Tue, Nov 21, 2023 at 02:39:05PM -0800, Eric Biggers wrote: > > This series adds a test that verifies the on-disk format of encrypted > > files that use a crypto data unit size that differs from the filesystem > > block size. This tests the functionality that was introduced in Linux > > 6.7 by kernel commit 5b1188847180 ("fscrypt: support crypto data unit > > size less than filesystem block size"). > > Hi Zorro, can you consider applying this series? It's been out for review for > 3 months, so I don't think reviews are going to come in. The prerequisite > xfsprogs patch is already present on the for-next branch of xfsprogs. Sure Eric, I thought about this patchset last week, I saw that xfsprogs patchset has been merge. I'll give this patchset a basic test, to make sure it won't break xfstests, then merge it. Thanks, and sorry this late. Zorro > > Thanks! > > - Eric >
This series adds a test that verifies the on-disk format of encrypted files that use a crypto data unit size that differs from the filesystem block size. This tests the functionality that was introduced in Linux 6.7 by kernel commit 5b1188847180 ("fscrypt: support crypto data unit size less than filesystem block size"). This depends on the xfsprogs patch "xfs_io/encrypt: support specifying crypto data unit size" (https://lore.kernel.org/r/20231013062639.141468-1-ebiggers@kernel.org) which adds the '-s' option to the set_encpolicy command of xfs_io. As usual, the test skips itself when any prerequisite isn't met. I've tested the new test on both ext4 and f2fs. Changed in v2: - Updated the cover letter, commit message, and a comment to reflect that the kernel commit that added this feature was merged in 6.7. - Rebased onto latest for-next branch of xfstests. Eric Biggers (4): fscrypt-crypt-util: rename block to data unit common/rc: fix _require_xfs_io_command with digits in argument common/encrypt: support custom data unit size generic: add test for custom crypto data unit size common/encrypt | 42 +++++++++++++----- common/rc | 2 +- src/fscrypt-crypt-util.c | 93 ++++++++++++++++++++-------------------- tests/f2fs/002 | 6 +-- tests/generic/900 | 29 +++++++++++++ tests/generic/900.out | 11 +++++ 6 files changed, 123 insertions(+), 60 deletions(-) create mode 100755 tests/generic/900 create mode 100644 tests/generic/900.out base-commit: b9e1a88f8198ac02f3b82fe3b127d4e14f4a97b7