From patchwork Tue Mar 5 10:15:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugen Hristev X-Patchwork-Id: 13582000 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE1A1C54E41 for ; Tue, 5 Mar 2024 10:16:39 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rhRqf-0004IN-CB; Tue, 05 Mar 2024 10:16:38 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rhRqe-0004I5-B9 for linux-f2fs-devel@lists.sourceforge.net; Tue, 05 Mar 2024 10:16:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=prhBV3AD6wPGEmJOiPV1noI0wHQ/KY6pKMN3W0SziRo=; b=lTUxqETxXefsAdQnMXWUnyZ4tg b36IyT4kVFlNhNhKBxFjy6JTa7e+l9/KRX+o19xrRs/+DOMMTd4bmnsT8kgCBnJSXOaLtKYDzvPkl C5xIRFubKPIV+ZRngC+tzn4NykQ/jcvr8n59UfNNIRi5z7Xwd0XXF4cR5c6mF57hGMg8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=prhBV3AD6wPGEmJOiPV1noI0wHQ/KY6pKMN3W0SziRo=; b=P yOuFBuhHZqxVkMZezydIXQnx6iFJDaxnkE9d6+0fOnt4ZlOX9CIs1Z4qUARFOHDK2UMoZaaiqFasS SruAQRmItQs5WJXvjXwtXCoFzR3mdOO+g49ZzSxFiG8jKlIgWVFIDfJmt4wkWd0K/G+8uLrqnpK5o BSRCg5j0YxjAbZbw=; Received: from madrid.collaboradmins.com ([46.235.227.194]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rhRqW-0001uq-RP for linux-f2fs-devel@lists.sourceforge.net; Tue, 05 Mar 2024 10:16:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709633783; bh=i/9ZW+kNqpZnJVbMsf5b8+hAV2dVj/G+FqywABYCn2o=; h=From:To:Cc:Subject:Date:From; b=hIASFsMvENDZkfwrWl7aEgXOJK9SjbtAmPR07fRshhtuD4+jt406NG79i5DYiWELf Xghf/2KavoY3OIpydipg6j2iPOav0POFQALRPe2b6KL9SqfIkjMnhal0MOooaKAz3X VVy452exObbp+l5etRpn4D7aeBGDLeeVWGIrBIZOCHpgE+hhVB/9oS3m86etzuSuPD ILWevtXYjMl1kkw3yXnqC02zM1pt+jg5UfZfrcuHK5Tbn9549J+sOGID56mgnk3nk/ gD3KKHQf0fVPxu9lo3KdqF9ur4kdK856U/2dS1h3R8oBvKifVOmpARUqEOOyJ+jLS0 oFFRcSeC5P6EQ== Received: from eugen-station.domain.com (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ehristev) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 355D9378045F; Tue, 5 Mar 2024 10:16:20 +0000 (UTC) To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, jaegeuk@kernel.org, chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Date: Tue, 5 Mar 2024 12:15:59 +0200 Message-Id: <20240305101608.67943-1-eugen.hristev@collabora.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Headers-End: 1rhRqW-0001uq-RP Subject: [f2fs-dev] [PATCH v13 0/9] Cache insensitive cleanup for ext4/f2fs X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eugen Hristev via Linux-f2fs-devel From: Eugen Hristev Reply-To: Eugen Hristev Cc: krisman@suse.de, brauner@kernel.org, jack@suse.cz, linux-kernel@vger.kernel.org, eugen.hristev@collabora.com, viro@zeniv.linux.org.uk, kernel@collabora.com Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hello, I am trying to respin the series here : https://www.spinics.net/lists/linux-ext4/msg85081.html I resent some of the v9 patches and got some reviews from Gabriel, I did changes as requested and here is v13. Changes in v13: - removed stray wrong line in 2/8 - removed old R-b as it's too long since they were given - removed check for null buff in 2/8 - added new patch `f2fs: Log error when lookup of encoded dentry fails` as suggested - rebased on unicode.git for-next branch Changes in v12: - revert to v10 comparison with propagating the error code from utf comparison Changes in v11: - revert to the original v9 implementation for the comparison helper. Changes in v10: - reworked a bit the comparison helper to improve performance by first performing the exact lookup. * Original commit letter The case-insensitive implementations in f2fs and ext4 have quite a bit of duplicated code. This series simplifies the ext4 version, with the goal of extracting ext4_ci_compare into a helper library that can be used by both filesystems. It also reduces the clutter from many codeguards for CONFIG_UNICODE; as requested by Linus, they are part of the codeflow now. While there, I noticed we can leverage the utf8 functions to detect encoded names that are corrupted in the filesystem. Therefore, it also adds an ext4 error on that scenario, to mark the filesystem as corrupted. This series survived passes of xfstests -g quick. Eugen Hristev (1): f2fs: Log error when lookup of encoded dentry fails Gabriel Krisman Bertazi (8): ext4: Simplify the handling of cached insensitive names f2fs: Simplify the handling of cached insensitive names libfs: Introduce case-insensitive string comparison helper ext4: Reuse generic_ci_match for ci comparisons f2fs: Reuse generic_ci_match for ci comparisons ext4: Log error when lookup of encoded dentry fails ext4: Move CONFIG_UNICODE defguards into the code flow f2fs: Move CONFIG_UNICODE defguards into the code flow fs/ext4/crypto.c | 19 ++----- fs/ext4/ext4.h | 35 +++++++----- fs/ext4/namei.c | 129 ++++++++++++++++----------------------------- fs/ext4/super.c | 4 +- fs/f2fs/dir.c | 112 ++++++++++++++------------------------- fs/f2fs/f2fs.h | 16 +++++- fs/f2fs/namei.c | 10 ++-- fs/f2fs/recovery.c | 5 +- fs/f2fs/super.c | 8 +-- fs/libfs.c | 81 ++++++++++++++++++++++++++++ include/linux/fs.h | 4 ++ 11 files changed, 219 insertions(+), 204 deletions(-)