| Message ID | 20221229131828.59116-1-frank.li@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a1357a91ec9ee72cf7683ac17b5f26dd5b4e6e5f |
| Headers | show |
| Series | [f2fs-dev] f2fs: mark f2fs_init_compress_mempool w/ __init | expand |
On 2022/12/29 21:18, Yangtao Li wrote: > f2fs_init_compress_mempool() only initializes the memory pool during > the f2fs module init phase. Let's mark it as __init like any other > function. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Thu, 29 Dec 2022 21:18:28 +0800 you wrote: > f2fs_init_compress_mempool() only initializes the memory pool during > the f2fs module init phase. Let's mark it as __init like any other > function. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > fs/f2fs/compress.c | 2 +- > fs/f2fs/f2fs.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Here is the summary with links: - [f2fs-dev] f2fs: mark f2fs_init_compress_mempool w/ __init https://git.kernel.org/jaegeuk/f2fs/c/a1357a91ec9e You are awesome, thank you!
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c index 2532f369cb10..c2cedff18827 100644 --- a/fs/f2fs/compress.c +++ b/fs/f2fs/compress.c @@ -564,7 +564,7 @@ module_param(num_compress_pages, uint, 0444); MODULE_PARM_DESC(num_compress_pages, "Number of intermediate compress pages to preallocate"); -int f2fs_init_compress_mempool(void) +int __init f2fs_init_compress_mempool(void) { compress_page_pool = mempool_create_page_pool(num_compress_pages, 0); return compress_page_pool ? 0 : -ENOMEM; diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index e8953c3dc81a..7367b0521f77 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -4259,7 +4259,7 @@ bool f2fs_compress_write_end(struct inode *inode, void *fsdata, int f2fs_truncate_partial_cluster(struct inode *inode, u64 from, bool lock); void f2fs_compress_write_end_io(struct bio *bio, struct page *page); bool f2fs_is_compress_backend_ready(struct inode *inode); -int f2fs_init_compress_mempool(void); +int __init f2fs_init_compress_mempool(void); void f2fs_destroy_compress_mempool(void); void f2fs_decompress_cluster(struct decompress_io_ctx *dic, bool in_task); void f2fs_end_read_compressed_page(struct page *page, bool failed, @@ -4328,7 +4328,7 @@ static inline struct page *f2fs_compress_control_page(struct page *page) WARN_ON_ONCE(1); return ERR_PTR(-EINVAL); } -static inline int f2fs_init_compress_mempool(void) { return 0; } +static inline int __init f2fs_init_compress_mempool(void) { return 0; } static inline void f2fs_destroy_compress_mempool(void) { } static inline void f2fs_decompress_cluster(struct decompress_io_ctx *dic, bool in_task) { }
f2fs_init_compress_mempool() only initializes the memory pool during the f2fs module init phase. Let's mark it as __init like any other function. Signed-off-by: Yangtao Li <frank.li@vivo.com> --- fs/f2fs/compress.c | 2 +- fs/f2fs/f2fs.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)