| Message ID | 20230104112158.15844-1-frank.li@vivo.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [f2fs-dev,1/4] f2fs: reset iostat_count in f2fs_reset_iostat() | expand |
Hi Yangtao, These are all in dev-test branch, which means you don't need to stack up more patches on top of it. I just integrated most of them into two original patches. Could you please take a look at this? c1706cc0cd72 f2fs: add iostat support for flush acd6f525e01c f2fs: support accounting iostat count and avg_bytes https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/log/?h=dev-test Thanks, On 01/04, Yangtao Li wrote: > Commit 8754b465c249 ("f2fs: support accounting iostat count and avg_bytes") > forgot to reset iostat count in f2fs_reset_iostat(), let's fix it. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > fs/f2fs/iostat.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/f2fs/iostat.c b/fs/f2fs/iostat.c > index c53b62a7ca71..8460989e9bab 100644 > --- a/fs/f2fs/iostat.c > +++ b/fs/f2fs/iostat.c > @@ -220,6 +220,7 @@ void f2fs_reset_iostat(struct f2fs_sb_info *sbi) > > spin_lock_irq(&sbi->iostat_lock); > for (i = 0; i < NR_IO_TYPE; i++) { > + sbi->iostat_count[i] = 0; > sbi->rw_iostat[i] = 0; > sbi->prev_rw_iostat[i] = 0; > } > -- > 2.25.1
On 2023/1/5 3:20, Jaegeuk Kim wrote: > Hi Yangtao, > > These are all in dev-test branch, which means you don't need to stack up more > patches on top of it. I just integrated most of them into two original patches. > Could you please take a look at this? > > c1706cc0cd72 f2fs: add iostat support for flush > acd6f525e01c f2fs: support accounting iostat count and avg_bytes +#define IOSTAT_INFO_SHOW(name, type) \ + seq_printf(seq, "%-23s %-16llu %-16llu %-16llu\n", \ + name":", sbi->iostat_bytes[type], \ + sbi->iostat_count[type], \ + iostat_get_avg_bytes(sbi, type)) \ '\' doesn't align in column, otherwise it looks good to me. Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
On 01/11, Chao Yu wrote: > On 2023/1/5 3:20, Jaegeuk Kim wrote: > > Hi Yangtao, > > > > These are all in dev-test branch, which means you don't need to stack up more > > patches on top of it. I just integrated most of them into two original patches. > > Could you please take a look at this? > > > > c1706cc0cd72 f2fs: add iostat support for flush > > acd6f525e01c f2fs: support accounting iostat count and avg_bytes > > +#define IOSTAT_INFO_SHOW(name, type) \ > + seq_printf(seq, "%-23s %-16llu %-16llu %-16llu\n", \ > + name":", sbi->iostat_bytes[type], \ > + sbi->iostat_count[type], \ > + iostat_get_avg_bytes(sbi, type)) \ > > '\' doesn't align in column, otherwise it looks good to me. Applied with the fix. > > Reviewed-by: Chao Yu <chao@kernel.org> > > Thanks,
Dear Jaegeuk, > Hi Yangtao, > > These are all in dev-test branch, which means you don't need to stack up more > patches on top of it. I just integrated most of them into two original patches. Ok, I'll merge the previous commits and resend next time. > Could you please take a look at this? LGTM. > Applied with the fix. Thanks! BTW, I would like to ask whether it is possible to maintain discard in separated file. https://patchwork.kernel.org/project/f2fs/patch/20221217132318.37718-1-frank.li@vivo.com/ MBR, Yangtao
On 01/12, Yangtao Li wrote: > Dear Jaegeuk, > > > Hi Yangtao, > > > > These are all in dev-test branch, which means you don't need to stack up more > > patches on top of it. I just integrated most of them into two original patches. > > Ok, I'll merge the previous commits and resend next time. > > > Could you please take a look at this? > > LGTM. > > > Applied with the fix. > > Thanks! > > BTW, I would like to ask whether it is possible to maintain discard in separated file. > > https://patchwork.kernel.org/project/f2fs/patch/20221217132318.37718-1-frank.li@vivo.com/ Not worth. > > MBR, > Yangtao
diff --git a/fs/f2fs/iostat.c b/fs/f2fs/iostat.c index c53b62a7ca71..8460989e9bab 100644 --- a/fs/f2fs/iostat.c +++ b/fs/f2fs/iostat.c @@ -220,6 +220,7 @@ void f2fs_reset_iostat(struct f2fs_sb_info *sbi) spin_lock_irq(&sbi->iostat_lock); for (i = 0; i < NR_IO_TYPE; i++) { + sbi->iostat_count[i] = 0; sbi->rw_iostat[i] = 0; sbi->prev_rw_iostat[i] = 0; }
Commit 8754b465c249 ("f2fs: support accounting iostat count and avg_bytes") forgot to reset iostat count in f2fs_reset_iostat(), let's fix it. Signed-off-by: Yangtao Li <frank.li@vivo.com> --- fs/f2fs/iostat.c | 1 + 1 file changed, 1 insertion(+)