| Message ID | 20230123094601.32940-1-frank.li@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0f837b84b2af390a17546e7b4ab5ef48ecf2d8e6 |
| Headers | show |
| Series | [f2fs-dev] f2fs: allow set compression option of files without blocks | expand |
On 2023/1/23 17:46, Yangtao Li wrote: > Files created by truncate have a size but no blocks, so > they can be allowed to set compression option. > > Fixes: e1e8debec656 ("f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl") > Signed-off-by: Yangtao Li <frank.li@vivo.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Mon, 23 Jan 2023 17:46:01 +0800 you wrote: > Files created by truncate have a size but no blocks, so > they can be allowed to set compression option. > > Fixes: e1e8debec656 ("f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl") > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > fs/f2fs/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [f2fs-dev] f2fs: allow set compression option of files without blocks https://git.kernel.org/jaegeuk/f2fs/c/0f837b84b2af You are awesome, thank you!
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index b3bcb50490bd..fda04c37b48c 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -3990,7 +3990,7 @@ static int f2fs_ioc_set_compress_option(struct file *filp, unsigned long arg, goto out; } - if (inode->i_size != 0) { + if (F2FS_HAS_BLOCKS(inode)) { ret = -EFBIG; goto out; }
Files created by truncate have a size but no blocks, so they can be allowed to set compression option. Fixes: e1e8debec656 ("f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl") Signed-off-by: Yangtao Li <frank.li@vivo.com> --- fs/f2fs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)