| Message ID | 20230319075822.79337-1-frank.li@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 08d04e0156f36b8360a79909987c6a950f099508 |
| Headers | show |
| Series | [f2fs-dev,RESEND] f2fs: convert is_extension_exist() to return bool type | expand |
On 2023/3/19 15:58, Yangtao Li wrote: > is_extension_exist() only return two values, 0 or 1. > So there is no need to use int type. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Sun, 19 Mar 2023 15:58:22 +0800 you wrote: > is_extension_exist() only return two values, 0 or 1. > So there is no need to use int type. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > Resend this patch because there is no similar patch to merge in this time. > fs/f2fs/namei.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Here is the summary with links: - [f2fs-dev,RESEND] f2fs: convert is_extension_exist() to return bool type https://git.kernel.org/jaegeuk/f2fs/c/08d04e0156f3 You are awesome, thank you!
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index 11fc4c8036a9..ad597b417fea 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -22,7 +22,7 @@ #include "acl.h" #include <trace/events/f2fs.h> -static inline int is_extension_exist(const unsigned char *s, const char *sub, +static inline bool is_extension_exist(const unsigned char *s, const char *sub, bool tmp_ext) { size_t slen = strlen(s); @@ -30,19 +30,19 @@ static inline int is_extension_exist(const unsigned char *s, const char *sub, int i; if (sublen == 1 && *sub == '*') - return 1; + return true; /* * filename format of multimedia file should be defined as: * "filename + '.' + extension + (optional: '.' + temp extension)". */ if (slen < sublen + 2) - return 0; + return false; if (!tmp_ext) { /* file has no temp extension */ if (s[slen - sublen - 1] != '.') - return 0; + return false; return !strncasecmp(s + slen - sublen, sub, sublen); } @@ -50,10 +50,10 @@ static inline int is_extension_exist(const unsigned char *s, const char *sub, if (s[i] != '.') continue; if (!strncasecmp(s + i + 1, sub, sublen)) - return 1; + return true; } - return 0; + return false; } int f2fs_update_extension_list(struct f2fs_sb_info *sbi, const char *name,
is_extension_exist() only return two values, 0 or 1. So there is no need to use int type. Signed-off-by: Yangtao Li <frank.li@vivo.com> --- Resend this patch because there is no similar patch to merge in this time. fs/f2fs/namei.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)