| Message ID | 20230527001539.3608665-1-chao@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cd2a3af38096968571c4d88696d5062008404171 |
| Headers | show |
| Series | [f2fs-dev,v3] f2fs: fix to set noatime and immutable flag for quota file | expand |
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Sat, 27 May 2023 08:15:39 +0800 you wrote: > We should set noatime bit for quota files, since no one cares about > atime of quota file, and we should set immutalbe bit as well, due to > nobody should write to the file through exported interfaces. > > Meanwhile this patch use inode_lock to avoid race condition during > inode->i_flags, f2fs_inode->i_flags update. > > [...] Here is the summary with links: - [f2fs-dev,v3] f2fs: fix to set noatime and immutable flag for quota file https://git.kernel.org/jaegeuk/f2fs/c/cd2a3af38096 You are awesome, thank you!
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 51812f459581..8eb17cc73941 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -2748,6 +2748,7 @@ static int f2fs_quota_enable(struct super_block *sb, int type, int format_id, { struct inode *qf_inode; unsigned long qf_inum; + unsigned long qf_flag = F2FS_NOATIME_FL | F2FS_IMMUTABLE_FL; int err; BUG_ON(!f2fs_sb_has_quota_ino(F2FS_SB(sb))); @@ -2763,7 +2764,15 @@ static int f2fs_quota_enable(struct super_block *sb, int type, int format_id, } /* Don't account quota for quota files to avoid recursion */ + inode_lock(qf_inode); qf_inode->i_flags |= S_NOQUOTA; + + if ((F2FS_I(qf_inode)->i_flags & qf_flag) != qf_flag) { + F2FS_I(qf_inode)->i_flags |= qf_flag; + f2fs_set_inode_flags(qf_inode); + } + inode_unlock(qf_inode); + err = dquot_load_quota_inode(qf_inode, type, format_id, flags); iput(qf_inode); return err;
We should set noatime bit for quota files, since no one cares about atime of quota file, and we should set immutalbe bit as well, due to nobody should write to the file through exported interfaces. Meanwhile this patch use inode_lock to avoid race condition during inode->i_flags, f2fs_inode->i_flags update. Signed-off-by: Chao Yu <chao@kernel.org> --- v3: - simply check condition suggested by Jaegeuk. fs/f2fs/super.c | 9 +++++++++ 1 file changed, 9 insertions(+)