From patchwork Thu Jun 8 10:12:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chao Yu X-Patchwork-Id: 13271874 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B7AAC7EE23 for ; Thu, 8 Jun 2023 10:12:46 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1q7CdJ-0003DQ-W3; Thu, 08 Jun 2023 10:12:46 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q7CdI-0003DA-5M for linux-f2fs-devel@lists.sourceforge.net; Thu, 08 Jun 2023 10:12:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vW9Pg3025r7tvGJQCvfoCPcgA0cDwnTwjIgJuW7mEx0=; b=Qs/Y/wKe1lKxyUX5Kxrc3Gv6RN XtTbCIcvoO1L3WcVn/gg5XLdUgd4okjXX2w9kZ3M4U9GEHDEGNpZNb+qxPEEqSbcETZdmdq90iXmN TSMqslEPnuvEbKW3HRXzz1yya2qfEpIFCgEmXFf7bVOX8awn4ZADq8FqzunNq9gAjV/4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=vW9Pg3025r7tvGJQCvfoCPcgA0cDwnTwjIgJuW7mEx0=; b=R dB8kEaQLClH9VCKIEKmXI7Uo+wr4d3K9p7Hi06POLD9HUxC0x2njJSDJFRtrbp5MdFmqU724jijAX 5Is5uumpqnqgD5yLgxzO7aK9Ti4BViB0HkHZzjjoUyxYFmXXk90Pw4AH8To7ACwupEyJ8wqaCd1bd Yo2oJ19FNUFKO/aY=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1q7CdH-00Ebdg-Jk for linux-f2fs-devel@lists.sourceforge.net; Thu, 08 Jun 2023 10:12:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3930B61866 for ; Thu, 8 Jun 2023 10:12:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD7B5C4339C; Thu, 8 Jun 2023 10:12:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686219157; bh=4e3yJa9fSjX/Z/iF3gNTTDJB/YVfizwvnPCS8mnBgzU=; h=From:To:Cc:Subject:Date:From; b=gGsmp47QZArgcGmKwSYyX9BHTedwg7hONg45j5xd/e0J28dnHD2t9XTHUbaOXCIHI G6ikfrq8q1kIyDZIxLaDy1eG2dmOPeSj+9LVssk92g7D/Hji2myNLXwEjLAuGoHueS dgODBfUPgrNgTtbIAhS8bb8soWzKdIC8dmSVdquw2ac3RYjLwC/R6ZvJoQt2gUPd8p LutVBqNhK4STZ2ae6mJmdrSB2v4zmVM9md0BPd2wKTIxZzvzNbbi10ADchDBDXLvz9 A3hyCnOjGgi7d9hlQ15xA4VHVrcVHpDr/fUuLCik9DPfjPlqs8Bz+iMOaLRBeJU9/i vxLpIKzIVEXOQ== From: Chao Yu To: jaegeuk@kernel.org Date: Thu, 8 Jun 2023 18:12:30 +0800 Message-Id: <20230608101230.3671677-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Headers-End: 1q7CdH-00Ebdg-Jk Subject: [f2fs-dev] [PATCH] f2fs-tools: fix to call assert() if f2fs_dentry_hash() fails X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net f2fs_dentry_hash() may return -ENOMEM due to malloc() failure, however caller won't check validaty of return value, result assign or check wrong hash value, fix to call assert() for such case. Signed-off-by: Chao Yu --- lib/libf2fs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libf2fs.c b/lib/libf2fs.c index 7a08a7f..0ab7342 100644 --- a/lib/libf2fs.c +++ b/lib/libf2fs.c @@ -497,8 +497,8 @@ f2fs_hash_t f2fs_dentry_hash(int encoding, int casefolded, if (len && casefolded) { buff = malloc(sizeof(char) * PATH_MAX); - if (!buff) - return -ENOMEM; + ASSERT(buff); + dlen = table->ops->casefold(table, name, len, buff, PATH_MAX); if (dlen < 0) { free(buff);