| Message ID | 20230627122153.1557656-1-shengyong@oppo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 87a91a155902f2b652e272ad3ba4de3486af9229 |
| Headers | show |
| Series | [f2fs-dev,RFC] f2fs: only set release for file that has compressed data | expand |
On 2023/6/27 20:21, Sheng Yong wrote: > If a file is not comprssed yet or does not have compressed data, > for example, its data has a very low compression ratio, do not > set FI_COMPRESS_RELEASED flag. > > Signed-off-by: Sheng Yong <shengyong@oppo.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Tue, 27 Jun 2023 20:21:53 +0800 you wrote: > If a file is not comprssed yet or does not have compressed data, > for example, its data has a very low compression ratio, do not > set FI_COMPRESS_RELEASED flag. > > Signed-off-by: Sheng Yong <shengyong@oppo.com> > --- > fs/f2fs/file.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Here is the summary with links: - [f2fs-dev,RFC] f2fs: only set release for file that has compressed data https://git.kernel.org/jaegeuk/f2fs/c/87a91a155902 You are awesome, thank you!
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index b1a4de3b53e01..0f54c1ff02f71 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -3510,13 +3510,15 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg) if (ret) goto out; + if (!atomic_read(&F2FS_I(inode)->i_compr_blocks)) { + ret = -EPERM; + goto out; + } + set_inode_flag(inode, FI_COMPRESS_RELEASED); inode->i_ctime = current_time(inode); f2fs_mark_inode_dirty_sync(inode, true); - if (!atomic_read(&F2FS_I(inode)->i_compr_blocks)) - goto out; - f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); filemap_invalidate_lock(inode->i_mapping);
If a file is not comprssed yet or does not have compressed data, for example, its data has a very low compression ratio, do not set FI_COMPRESS_RELEASED flag. Signed-off-by: Sheng Yong <shengyong@oppo.com> --- fs/f2fs/file.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)