| Message ID | 20230629014102.3057853-1-chao@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0135c482fa97e2fd8245cb462784112a00ed1211 |
| Headers | show |
| Series | [f2fs-dev] f2fs: fix error path handling in truncate_dnode() | expand |
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Thu, 29 Jun 2023 09:41:02 +0800 you wrote: > If truncate_node() fails in truncate_dnode(), it missed to call > f2fs_put_page(), fix it. > > Fixes: 7735730d39d7 ("f2fs: fix to propagate error from __get_meta_page()") > Signed-off-by: Chao Yu <chao@kernel.org> > --- > fs/f2fs/node.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Here is the summary with links: - [f2fs-dev] f2fs: fix error path handling in truncate_dnode() https://git.kernel.org/jaegeuk/f2fs/c/0135c482fa97 You are awesome, thank you!
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 4a105a0cd794..dadea6b01888 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -943,8 +943,10 @@ static int truncate_dnode(struct dnode_of_data *dn) dn->ofs_in_node = 0; f2fs_truncate_data_blocks(dn); err = truncate_node(dn); - if (err) + if (err) { + f2fs_put_page(page, 1); return err; + } return 1; }
If truncate_node() fails in truncate_dnode(), it missed to call f2fs_put_page(), fix it. Fixes: 7735730d39d7 ("f2fs: fix to propagate error from __get_meta_page()") Signed-off-by: Chao Yu <chao@kernel.org> --- fs/f2fs/node.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)