| Message ID | 20230710061058.2303767-1-chao@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | df19023418cd424993f8eb0079cc0ebd20b5545a |
| Headers | show |
| Series | [f2fs-dev] f2fs: don't handle error case of f2fs_compress_alloc_page() | expand |
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Mon, 10 Jul 2023 14:10:58 +0800 you wrote: > f2fs_compress_alloc_page() uses mempool to allocate memory, it never > fail, don't handle error case in its callers. > > Signed-off-by: Chao Yu <chao@kernel.org> > --- > fs/f2fs/compress.c | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) Here is the summary with links: - [f2fs-dev] f2fs: don't handle error case of f2fs_compress_alloc_page() https://git.kernel.org/jaegeuk/f2fs/c/df19023418cd You are awesome, thank you!
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c index 236d890f560b..9662d635efbe 100644 --- a/fs/f2fs/compress.c +++ b/fs/f2fs/compress.c @@ -649,13 +649,8 @@ static int f2fs_compress_pages(struct compress_ctx *cc) goto destroy_compress_ctx; } - for (i = 0; i < cc->nr_cpages; i++) { + for (i = 0; i < cc->nr_cpages; i++) cc->cpages[i] = f2fs_compress_alloc_page(); - if (!cc->cpages[i]) { - ret = -ENOMEM; - goto out_free_cpages; - } - } cc->rbuf = f2fs_vmap(cc->rpages, cc->cluster_size); if (!cc->rbuf) { @@ -1574,8 +1569,6 @@ static int f2fs_prepare_decomp_mem(struct decompress_io_ctx *dic, } dic->tpages[i] = f2fs_compress_alloc_page(); - if (!dic->tpages[i]) - return -ENOMEM; } dic->rbuf = f2fs_vmap(dic->tpages, dic->cluster_size); @@ -1656,11 +1649,6 @@ struct decompress_io_ctx *f2fs_alloc_dic(struct compress_ctx *cc) struct page *page; page = f2fs_compress_alloc_page(); - if (!page) { - ret = -ENOMEM; - goto out_free; - } - f2fs_set_compressed_page(page, cc->inode, start_idx + i + 1, dic); dic->cpages[i] = page;
f2fs_compress_alloc_page() uses mempool to allocate memory, it never fail, don't handle error case in its callers. Signed-off-by: Chao Yu <chao@kernel.org> --- fs/f2fs/compress.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-)