| Message ID | 20230920004645.1462354-1-jaegeuk@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a3edf9f0bbb798f6c39b2bd467ee2d7fe425a0f8 |
| Headers | show |
| Series | [f2fs-dev] f2fs: preload extent_cache for POSIX_FADV_WILLNEED | expand |
On 2023/9/20 8:46, Jaegeuk Kim wrote: > This patch tries to preload extent_cache given POSIX_FADV_WILLNEED, which is > more useful for generic usecases. > > Suggested-by: Eric Biggers <ebiggers@kernel.org> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Tue, 19 Sep 2023 17:46:45 -0700 you wrote: > This patch tries to preload extent_cache given POSIX_FADV_WILLNEED, which is > more useful for generic usecases. > > Suggested-by: Eric Biggers <ebiggers@kernel.org> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > --- > fs/f2fs/file.c | 2 ++ > 1 file changed, 2 insertions(+) Here is the summary with links: - [f2fs-dev] f2fs: preload extent_cache for POSIX_FADV_WILLNEED https://git.kernel.org/jaegeuk/f2fs/c/a3edf9f0bbb7 You are awesome, thank you!
This patch tries to preload extent_cache given POSIX_FADV_WILLNEED, which is more useful for generic usecases. Reviewed-by: Chao Yu <chao@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> --- Change log from v1: - load it at offset=0 once to avoid reloading for all the calls fs/f2fs/file.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 09716127e107..161826c6e200 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -4858,6 +4858,9 @@ static int f2fs_file_fadvise(struct file *filp, loff_t offset, loff_t len, filp->f_mode &= ~FMODE_RANDOM; spin_unlock(&filp->f_lock); return 0; + } else if (advice == POSIX_FADV_WILLNEED && offset == 0) { + /* Load extent cache at the first readahead. */ + f2fs_precache_extents(inode); } err = generic_fadvise(filp, offset, len, advice);
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 09716127e107..df7703c1f7d7 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -4858,6 +4858,8 @@ static int f2fs_file_fadvise(struct file *filp, loff_t offset, loff_t len, filp->f_mode &= ~FMODE_RANDOM; spin_unlock(&filp->f_lock); return 0; + } else if (advice == POSIX_FADV_WILLNEED) { + f2fs_precache_extents(inode); } err = generic_fadvise(filp, offset, len, advice);
This patch tries to preload extent_cache given POSIX_FADV_WILLNEED, which is more useful for generic usecases. Suggested-by: Eric Biggers <ebiggers@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> --- fs/f2fs/file.c | 2 ++ 1 file changed, 2 insertions(+)