| Message ID | 20240326061043.1348968-1-heyunlei@oppo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ac5eecf481c29942eb9a862e758c0c8b68090c33 |
| Headers | show |
| Series | [f2fs-dev] f2fs: remove clear SB_INLINECRYPT flag in default_options | expand |
On 2024/3/26 14:10, Yunlei He wrote: > In f2fs_remount, SB_INLINECRYPT flag will be clear and re-set. > If create new file or open file during this gap, these files > will not use inlinecrypt. Worse case, it may lead to data > corruption if wrappedkey_v0 is enable. > > Thread A: Thread B: > > -f2fs_remount -f2fs_file_open or f2fs_new_inode > -default_options > <- clear SB_INLINECRYPT flag > > -fscrypt_select_encryption_impl > > -parse_options > <- set SB_INLINECRYPT again > > Signed-off-by: Yunlei He <heyunlei@oppo.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Tue, 26 Mar 2024 14:10:43 +0800 you wrote: > In f2fs_remount, SB_INLINECRYPT flag will be clear and re-set. > If create new file or open file during this gap, these files > will not use inlinecrypt. Worse case, it may lead to data > corruption if wrappedkey_v0 is enable. > > Thread A: Thread B: > > [...] Here is the summary with links: - [f2fs-dev] f2fs: remove clear SB_INLINECRYPT flag in default_options https://git.kernel.org/jaegeuk/f2fs/c/ac5eecf481c2 You are awesome, thank you!
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index a6867f26f141..164eed42503b 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -2132,8 +2132,6 @@ static void default_options(struct f2fs_sb_info *sbi, bool remount) F2FS_OPTION(sbi).memory_mode = MEMORY_MODE_NORMAL; F2FS_OPTION(sbi).errors = MOUNT_ERRORS_CONTINUE; - sbi->sb->s_flags &= ~SB_INLINECRYPT; - set_opt(sbi, INLINE_XATTR); set_opt(sbi, INLINE_DATA); set_opt(sbi, INLINE_DENTRY);
In f2fs_remount, SB_INLINECRYPT flag will be clear and re-set. If create new file or open file during this gap, these files will not use inlinecrypt. Worse case, it may lead to data corruption if wrappedkey_v0 is enable. Thread A: Thread B: -f2fs_remount -f2fs_file_open or f2fs_new_inode -default_options <- clear SB_INLINECRYPT flag -fscrypt_select_encryption_impl -parse_options <- set SB_INLINECRYPT again Signed-off-by: Yunlei He <heyunlei@oppo.com> --- fs/f2fs/super.c | 2 -- 1 file changed, 2 deletions(-)