From patchwork Tue Jun 25 14:02:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chao Yu X-Patchwork-Id: 13711233 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB0A3C2BBCA for ; Tue, 25 Jun 2024 14:02:49 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sM6ky-0000ez-2e; Tue, 25 Jun 2024 14:02:48 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sM6kw-0000et-Bs for linux-f2fs-devel@lists.sourceforge.net; Tue, 25 Jun 2024 14:02:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UI6SRPMhpq83+LVj7HjgyImNSKqGo7GC194OmZd0ZRw=; b=U3xD8MQMcr+k/QZ+n/x644ZPNV 6TvL29fOaceAPn+DH4kDVljwzPMkhHwP76eM7VsOv9BCmzg/hmyFD41nGfWT6NCPsumczeugBtl+S /q0cPfKd8UkonAzhvwqUVEbhUQAamV6L2Sz3Fv0Nlj/Fj3/p1eU8AwyyZVPNWCUdxsh8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=UI6SRPMhpq83+LVj7HjgyImNSKqGo7GC194OmZd0ZRw=; b=K uzhx5T2qfMnN33tuvNwStgv6L3HnJO3W2Hl0ulm1WEy/K0Uwop3ImOZufRRmxyS3U/spTWxb8penM 8iXJxHnnsd4B4VGLx2JCVHz/tnZB3gmv5RTgcRulwGmUJYUMUIidl4/8uDRdn515sx/58lk2BrVLp jJolyduk6Kq6+Ogw=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1sM6kw-0004B6-SQ for linux-f2fs-devel@lists.sourceforge.net; Tue, 25 Jun 2024 14:02:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BD16461454; Tue, 25 Jun 2024 14:02:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F4177C32781; Tue, 25 Jun 2024 14:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719324160; bh=5UjL4GyZrjz619WsFq1WHy8mcigCmMBJuw6biomyaJU=; h=From:To:Cc:Subject:Date:From; b=RrpH7IF5FEgP1IJSfWRQ9+74A11Jaz23GSmjPswh4v3g/J1K6SXfboqD8BLAGoZob CWwufwqM3CylgWg2sAajvlO0GI44G+r52edV+mPu3G5rdMu8iaFv5zXiNBnk2sYwD+ MJr5mPgVccNYjszsTtmxv8/AwySfLMUAxrINmyeLbqDX+cBhT3Ly3ZhJUMrolvx2XP I6E6kUhncJbMlRyONW2Dx0GNUgRf/HfPJG/iL62DIlRYLjeQCPlAnb8TRzw/nXYMYo vIhcZNQQ8xz5IF57XsHctiNv4d0PIo/7hZzgjn8qdQDSyZAXo/HdBK6sJiQpJIdZ1h B2ENuIT4NgaCQ== From: Chao Yu To: Zorro Lang Date: Tue, 25 Jun 2024 22:02:33 +0800 Message-Id: <20240625140233.3907012-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Headers-End: 1sM6kw-0004B6-SQ Subject: [f2fs-dev] [PATCH] f2fs: test for race condition in between atomic_write and dio X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim , Daeho Jeong , fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net In this patch, we simulate race case in between sqlite atomic write and direct IO w/ below steps: 1. create a regular file, and initialize it w/ 0xff data 2. start transaction (via F2FS_IOC_START_ATOMIC_WRITE) on it 3. write transaction data 4. trigger direct read/write IO on it to check whether it fails or not 5. commit and end the transaction (via F2FS_IOC_COMMIT_ATOMIC_WRITE) This is a regression test to check handling of race condition in between atomic_write and direct IO. Cc: Jaegeuk Kim Cc: Daeho Jeong Signed-off-by: Chao Yu --- tests/f2fs/004 | 45 +++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/004.out | 3 +++ 2 files changed, 48 insertions(+) create mode 100755 tests/f2fs/004 create mode 100644 tests/f2fs/004.out diff --git a/tests/f2fs/004 b/tests/f2fs/004 new file mode 100755 index 00000000..26862cb5 --- /dev/null +++ b/tests/f2fs/004 @@ -0,0 +1,45 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2024 Oppo. All Rights Reserved. +# +# FS QA Test No. f2fs/004 +# +# Test that we will simulate race case in between sqlite atomic write +# and direct IO w/ below steps: +# 1. create a regular file, and initialize it w/ 0xff data +# 2. start transaction (via F2FS_IOC_START_ATOMIC_WRITE) on it +# 3. write transaction data +# 4. trigger direct read/write IO to check whether it fails or not +# 5. commit and end the transaction (via F2FS_IOC_COMMIT_ATOMIC_WRITE) +# This is a regression test to check handling of race condition in +# between atomic_write and direct IO. +# +. ./common/preamble +_begin_fstest auto quick + +. ./common/filter + +_supported_fs f2fs +_require_scratch +_require_xfs_io_command "pwrite" + +_scratch_mkfs >> $seqres.full +_scratch_mount >> $seqres.full + +dbfile=$SCRATCH_MNT/dbfile + +# start atomic_write on dbfile & write data to dbfile +touch $dbfile +$F2FS_IO_PROG write 1 0 32 zero atomic_commit $dbfile 3000 >> $seqres.full & + +# simulate concurrent direct read/write IO +$XFS_IO_PROG -d -c "pread 0 128k" $dbfile +$XFS_IO_PROG -d -c "pwrite 0 128k" $dbfile + +# wait for atomic_write commit completion +sleep 5 + +_scratch_unmount + +status=0 +exit diff --git a/tests/f2fs/004.out b/tests/f2fs/004.out new file mode 100644 index 00000000..3af79541 --- /dev/null +++ b/tests/f2fs/004.out @@ -0,0 +1,3 @@ +QA output created by 004 +pread: Operation not supported +pwrite: Operation not supported