| Message ID | 20240708120407.2807639-1-shengyong@oppo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8c409989678e92e4a737e7cd2bb04f3efb81071a |
| Headers | show |
| Series | [f2fs-dev,v2] f2fs: fix start segno of large section | expand |
On 2024/7/8 20:04, Sheng Yong wrote: > get_ckpt_valid_blocks() checks valid ckpt blocks in current section. > It counts all vblocks from the first to the last segment in the > large section. However, START_SEGNO() is used to get the first segno > in an SIT block. This patch fixes that to get the correct start segno. > > Fixes: 61461fc921b7 ("f2fs: fix to avoid touching checkpointed data in get_victim()") > Signed-off-by: Sheng Yong <shengyong@oppo.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Mon, 8 Jul 2024 20:04:07 +0800 you wrote: > get_ckpt_valid_blocks() checks valid ckpt blocks in current section. > It counts all vblocks from the first to the last segment in the > large section. However, START_SEGNO() is used to get the first segno > in an SIT block. This patch fixes that to get the correct start segno. > > Fixes: 61461fc921b7 ("f2fs: fix to avoid touching checkpointed data in get_victim()") > Signed-off-by: Sheng Yong <shengyong@oppo.com> > > [...] Here is the summary with links: - [f2fs-dev,v2] f2fs: fix start segno of large section https://git.kernel.org/jaegeuk/f2fs/c/8c409989678e You are awesome, thank you!
diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h index e1c0f418aa11..bfc01a521cb9 100644 --- a/fs/f2fs/segment.h +++ b/fs/f2fs/segment.h @@ -347,7 +347,8 @@ static inline unsigned int get_ckpt_valid_blocks(struct f2fs_sb_info *sbi, unsigned int segno, bool use_section) { if (use_section && __is_large_section(sbi)) { - unsigned int start_segno = START_SEGNO(segno); + unsigned int secno = GET_SEC_FROM_SEG(sbi, segno); + unsigned int start_segno = GET_SEG_FROM_SEC(sbi, secno); unsigned int blocks = 0; int i;
get_ckpt_valid_blocks() checks valid ckpt blocks in current section. It counts all vblocks from the first to the last segment in the large section. However, START_SEGNO() is used to get the first segno in an SIT block. This patch fixes that to get the correct start segno. Fixes: 61461fc921b7 ("f2fs: fix to avoid touching checkpointed data in get_victim()") Signed-off-by: Sheng Yong <shengyong@oppo.com> --- v2: use GET_SEC_FROM_SEG and GET_SEG_FROM_SEC to get start segno of section --- fs/f2fs/segment.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)