| Message ID | 20241111030456.2572093-1-jaegeuk@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [f2fs-dev] mkfs.f2fs: remove IMMUTABLE bit | expand |
Reviewed-by: Daeho Jeong <daehojeong@google.com> Thanks, On Sun, Nov 10, 2024 at 7:09 PM Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net> wrote: > > The immutable bit disallows selinux permission which gives no way to clear it. > > Fixes: 8cc4e257ec20 ("mkfs.f2fs: add device aliasing feature") > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > --- > mkfs/f2fs_format.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c > index 52a1e1864b29..6635eed99813 100644 > --- a/mkfs/f2fs_format.c > +++ b/mkfs/f2fs_format.c > @@ -1748,8 +1748,7 @@ static int f2fs_write_alias_inodes(void) > dev_off++; > f2fs_init_inode(sb, raw_node, ino, mkfs_time, 0x81c0); > > - raw_node->i.i_flags = cpu_to_le32(F2FS_IMMUTABLE_FL | > - F2FS_DEVICE_ALIAS_FL); > + raw_node->i.i_flags = cpu_to_le32(F2FS_DEVICE_ALIAS_FL); > raw_node->i.i_inline = F2FS_PIN_FILE; > raw_node->i.i_pino = sb->root_ino; > filename = c.devices[i].alias_filename; > -- > 2.47.0.277.g8800431eea-goog > > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c index 52a1e1864b29..6635eed99813 100644 --- a/mkfs/f2fs_format.c +++ b/mkfs/f2fs_format.c @@ -1748,8 +1748,7 @@ static int f2fs_write_alias_inodes(void) dev_off++; f2fs_init_inode(sb, raw_node, ino, mkfs_time, 0x81c0); - raw_node->i.i_flags = cpu_to_le32(F2FS_IMMUTABLE_FL | - F2FS_DEVICE_ALIAS_FL); + raw_node->i.i_flags = cpu_to_le32(F2FS_DEVICE_ALIAS_FL); raw_node->i.i_inline = F2FS_PIN_FILE; raw_node->i.i_pino = sb->root_ino; filename = c.devices[i].alias_filename;
The immutable bit disallows selinux permission which gives no way to clear it. Fixes: 8cc4e257ec20 ("mkfs.f2fs: add device aliasing feature") Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> --- mkfs/f2fs_format.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)