| Message ID | 20250202043253.64389-1-enjuk@amazon.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 53333cdf5b03870a8ed4f8d434bd98b3d6771d5f |
| Headers | show |
| Series | [f2fs-dev,v1] f2fs: remove unnecessary null checking | expand |
… > f2fs_bio_alloc() with bio_alloc_bioset(), but null checking after > bio_alloc_bioset() was still left. See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n94 Regards, Markus
On 2/1/25 9:32 PM, Kohei Enju wrote: > When __GFP_DIRECT_RECLAIM (included in both GFP_NOIO and GFP_KERNEL) is > specified, bio_alloc_bioset() never fails to allocate a bio. > Commit 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") replaced > f2fs_bio_alloc() with bio_alloc_bioset(), but null checking after > bio_alloc_bioset() was still left. Reviewed-by: Jens Axboe <axboe@kernel.dk>
On 2/2/25 12:32, Kohei Enju wrote: > When __GFP_DIRECT_RECLAIM (included in both GFP_NOIO and GFP_KERNEL) is > specified, bio_alloc_bioset() never fails to allocate a bio. > Commit 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") replaced > f2fs_bio_alloc() with bio_alloc_bioset(), but null checking after > bio_alloc_bioset() was still left. > > Fixes: 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") > Signed-off-by: Kohei Enju <enjuk@amazon.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Sun, 2 Feb 2025 13:32:53 +0900 you wrote: > When __GFP_DIRECT_RECLAIM (included in both GFP_NOIO and GFP_KERNEL) is > specified, bio_alloc_bioset() never fails to allocate a bio. > Commit 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") replaced > f2fs_bio_alloc() with bio_alloc_bioset(), but null checking after > bio_alloc_bioset() was still left. > > Fixes: 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") > Signed-off-by: Kohei Enju <enjuk@amazon.com> > > [...] Here is the summary with links: - [f2fs-dev,v1] f2fs: remove unnecessary null checking https://git.kernel.org/jaegeuk/f2fs/c/53333cdf5b03 You are awesome, thank you!
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index de4da6d9cd93..07b46b444d31 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -1041,8 +1041,6 @@ static struct bio *f2fs_grab_read_bio(struct inode *inode, block_t blkaddr, bio = bio_alloc_bioset(bdev, bio_max_segs(nr_pages), REQ_OP_READ | op_flag, for_write ? GFP_NOIO : GFP_KERNEL, &f2fs_bioset); - if (!bio) - return ERR_PTR(-ENOMEM); bio->bi_iter.bi_sector = sector; f2fs_set_bio_crypt_ctx(bio, inode, first_idx, NULL, GFP_NOFS); bio->bi_end_io = f2fs_read_end_io;
When __GFP_DIRECT_RECLAIM (included in both GFP_NOIO and GFP_KERNEL) is specified, bio_alloc_bioset() never fails to allocate a bio. Commit 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") replaced f2fs_bio_alloc() with bio_alloc_bioset(), but null checking after bio_alloc_bioset() was still left. Fixes: 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") Signed-off-by: Kohei Enju <enjuk@amazon.com> --- fs/f2fs/data.c | 2 -- 1 file changed, 2 deletions(-)